-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing data-test-subj tags for data plugin #9051
Open
LDrago27
wants to merge
4
commits into
opensearch-project:main
Choose a base branch
from
LDrago27:addDataTEstSubj
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Suchit Sahoo <[email protected]>
github-actions
bot
added
all-star-contributor
Skip-Changelog
PRs that are too trivial to warrant a changelog or release notes entry
labels
Dec 12, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9051 +/- ##
==========================================
- Coverage 60.87% 60.84% -0.04%
==========================================
Files 3808 3808
Lines 91209 91209
Branches 14410 14410
==========================================
- Hits 55526 55492 -34
- Misses 32142 32222 +80
+ Partials 3541 3495 -46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LDrago27
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
December 12, 2024 23:48
Signed-off-by: Suchit Sahoo <[email protected]>
ananzh
reviewed
Dec 13, 2024
src/plugins/data/public/query/query_string/language_service/lib/query_result.tsx
Outdated
Show resolved
Hide resolved
src/plugins/data/public/ui/query_editor/query_editor_top_row.tsx
Outdated
Show resolved
Hide resolved
LDrago27
force-pushed
the
addDataTEstSubj
branch
from
December 13, 2024 20:42
5bb43a9
to
0f42fcf
Compare
ananzh
reviewed
Dec 13, 2024
Signed-off-by: Suchit Sahoo <[email protected]>
LDrago27
force-pushed
the
addDataTEstSubj
branch
from
December 13, 2024 22:59
0f42fcf
to
528982a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
all-star-contributor
Skip-Changelog
PRs that are too trivial to warrant a changelog or release notes entry
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add missing data-test-subj tags for data plugin
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration