Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing data-test-subj tags for data plugin #9051

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

LDrago27
Copy link
Collaborator

Description

Add missing data-test-subj tags for data plugin

Issues Resolved

Screenshot

Testing the changes

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@github-actions github-actions bot added all-star-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Dec 12, 2024
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.84%. Comparing base (9f23442) to head (528982a).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...ta/public/ui/dataset_selector/dataset_explorer.tsx 0.00% 1 Missing ⚠️
...i/saved_query_management/saved_query_list_item.tsx 0.00% 1 Missing ⚠️
...failure_modal/shard_failure_description_header.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9051      +/-   ##
==========================================
- Coverage   60.87%   60.84%   -0.04%     
==========================================
  Files        3808     3808              
  Lines       91209    91209              
  Branches    14410    14410              
==========================================
- Hits        55526    55492      -34     
- Misses      32142    32222      +80     
+ Partials     3541     3495      -46     
Flag Coverage Δ
Linux_1 29.02% <0.00%> (ø)
Linux_2 ?
Linux_3 37.93% <0.00%> (+<0.01%) ⬆️
Linux_4 29.01% <0.00%> (ø)
Windows_1 29.03% <0.00%> (-0.02%) ⬇️
Windows_2 56.34% <ø> (ø)
Windows_3 37.93% <0.00%> (ø)
Windows_4 29.01% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Suchit Sahoo <[email protected]>
Signed-off-by: Suchit Sahoo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
all-star-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants