[Discover 2.0 Testing] TestId-69: Filtering

changelogs/fragments/8611.yml

@@ -0,0 +1,2 @@
+fix:
+- Bump url to 0.11.4 ([#8611](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/8611))

changelogs/fragments/8739.yml

@@ -0,0 +1,2 @@
+fix:
+- [Workspace] [Bug] Check if workspaces exists when creating saved objects. ([#8739](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/8739))

changelogs/fragments/8886.yml

@@ -0,0 +1,2 @@
+chore:
+- Bump `@opensearch-project/opensearch` from 2.9.0 to 2.13.0 ([#8886](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/8886))

changelogs/fragments/8888.yml

@@ -0,0 +1,2 @@
+refactor:
+- [Workspace] Isolate objects based on workspace when calling get/bulkGet ([#8888](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/8888))

changelogs/fragments/8900.yml

@@ -0,0 +1,2 @@
+feat:
+- Optimize recent items and filter out items whose workspace is deleted ([#8900](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/8900))

changelogs/fragments/8919.yml

@@ -0,0 +1,2 @@
+fix:
+- Change some of the http link in settings page to https link ([#8919](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/8919))

changelogs/fragments/8920.yml

@@ -0,0 +1,2 @@
+feat:
+- [workspace]support search dev tools by its category name ([#8920](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/8920))

changelogs/fragments/8930.yml

@@ -0,0 +1,2 @@
+fix:
+- Update saved search initialization logic to use current query instead of default query ([#8930](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/8930))

changelogs/fragments/8935.yml

@@ -0,0 +1,2 @@
+fix:
+- Use roundUp when converting timestamp for PPL ([#8935](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/8935))

changelogs/fragments/8951.yml

@@ -0,0 +1,2 @@
+fix:
+- SQL syntax highlighting double quotes ([#8951](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/8951))

cypress.config.ts

@@ -12,6 +12,7 @@ module.exports = defineConfig({
   responseTimeout: 60000,
   viewportWidth: 2000,
   viewportHeight: 1320,
+  retries: 2,
   env: {
     openSearchUrl: 'http://localhost:9200',
     SECURITY_ENABLED: false,
@@ -27,6 +28,7 @@ module.exports = defineConfig({
   },
   e2e: {
     baseUrl: 'http://localhost:5601',
+    supportFile: 'cypress/support/e2e.{js,jsx,ts,tsx}',
     specPattern: 'cypress/integration/**/*_spec.{js,jsx,ts,tsx}',
     testIsolation: false,
     setupNodeEvents,

cypress/integration/constants.js

@@ -0,0 +1,10 @@
+/*
+ * Copyright OpenSearch Contributors
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+export const INDEX_CLUSTER_NAME = 'data-logs-1';
+export const INDEX_NAME = 'data_logs_small_time_1';
+export const INDEX_PATTERN_NAME = 'data-logs-1::data_logs_small_time_1*';
+export const SEARCH_ABSOLUTE_START_DATE = 'Dec 31, 2020 @ 16:00:00.000';
+export const SEARCH_ABSOLUTE_END_DATE = 'Dec 31, 2022 @ 14:14:42.801';

cypress/integration/core_opensearch_dashboards/field_display_filtering_spec.js

@@ -0,0 +1,129 @@
+/*
+ * Copyright OpenSearch Contributors
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+import { MiscUtils } from '@opensearch-dashboards-test/opensearch-dashboards-test-library';
+import { DataExplorerPage } from '../../utils/dashboards/data_explorer/data_explorer_page.po';
+import {
+  INDEX_CLUSTER_NAME,
+  INDEX_NAME,
+  INDEX_PATTERN_NAME,
+  SEARCH_ABSOLUTE_START_DATE,
+  SEARCH_ABSOLUTE_END_DATE,
+} from '../constants.js';
+
+const miscUtils = new MiscUtils(cy);
+
+function selectDataSet(datasetType, language) {
+  switch (datasetType) {
+    case 'index':
+      DataExplorerPage.selectIndexDataset(INDEX_CLUSTER_NAME, INDEX_NAME, language);
+      break;
+    case 'index_pattern':
+      DataExplorerPage.selectIndexPatternDataset(INDEX_PATTERN_NAME, language);
+      if (language !== 'OpenSearch SQL') {
+        cy.setSearchAbsoluteDateRange(SEARCH_ABSOLUTE_START_DATE, SEARCH_ABSOLUTE_END_DATE);
+      }
+      break;
+  }
+}
+
+function checkTableFieldFilterActions(datasetType, language, isEnabled) {
+  selectDataSet(datasetType, language);
+
+  DataExplorerPage.getDiscoverQueryHits().should('not.exist'); // To ensure it waits until a full table is loaded into the DOM, instead of a bug where table only has 1 hit.
+
+  DataExplorerPage.checkDocTableFirstFieldFilterForAndOutButton(isEnabled);
+
+  if (isEnabled) {
+    DataExplorerPage.checkDocTableFirstFieldFilterForButtonFiltersCorrectField();
+    DataExplorerPage.checkDocTableFirstFieldFilterOutButtonFiltersCorrectField();
+  }
+}
+
+function checkExpandedTableFilterActions(datasetType, language, isEnabled) {
+  selectDataSet(datasetType, language);
+
+  DataExplorerPage.getDiscoverQueryHits().should('not.exist'); // To ensure it waits until a full table is loaded into the DOM, instead of a bug where table only has 1 hit.
+  DataExplorerPage.toggleDocTableRow(0);
+  DataExplorerPage.checkDocTableFirstExpandedFieldFirstRowFilterForFilterOutExistsFilterButtons(
+    isEnabled
+  );
+  DataExplorerPage.checkDocTableFirstExpandedFieldFirstRowToggleColumnButtonHasIntendedBehavior();
+
+  if (isEnabled) {
+    DataExplorerPage.checkDocTableFirstExpandedFieldFirstRowFilterForButtonFiltersCorrectField();
+    DataExplorerPage.checkDocTableFirstExpandedFieldFirstRowFilterOutButtonFiltersCorrectField();
+    DataExplorerPage.checkDocTableFirstExpandedFieldFirstRowExistsFilterButtonFiltersCorrectField();
+  }
+}
+
+describe('filter for value spec', () => {
+  beforeEach(() => {
+    cy.localLogin(Cypress.env('username'), Cypress.env('password'));
+    miscUtils.visitPage('app/data-explorer/discover');
+    cy.getNewSearchButton().click();
+  });
+  describe('filter actions in table field', () => {
+    describe('index pattern dataset', () => {
+      // filter actions should exist for DQL
+      it('DQL', () => {
+        checkTableFieldFilterActions('index_pattern', 'DQL', true);
+      });
+      // filter actions should exist for Lucene
+      it('Lucene', () => {
+        checkTableFieldFilterActions('index_pattern', 'Lucene', true);
+      });
+      // filter actions should not exist for SQL
+      it('SQL', () => {
+        checkTableFieldFilterActions('index_pattern', 'OpenSearch SQL', false);
+      });
+      // filter actions should not exist for PPL
+      it('PPL', () => {
+        checkTableFieldFilterActions('index_pattern', 'PPL', false);
+      });
+    });
+    describe('index dataset', () => {
+      // filter actions should not exist for SQL
+      it('SQL', () => {
+        checkTableFieldFilterActions('index', 'OpenSearch SQL', false);
+      });
+      // filter actions should not exist for PPL
+      it('PPL', () => {
+        checkTableFieldFilterActions('index', 'PPL', false);
+      });
+    });
+  });
+
+  describe('filter actions in expanded table', () => {
+    describe('index pattern dataset', () => {
+      // filter actions should exist for DQL
+      it('DQL', () => {
+        checkExpandedTableFilterActions('index_pattern', 'DQL', true);
+      });
+      // filter actions should exist for Lucene
+      it('Lucene', () => {
+        checkExpandedTableFilterActions('index_pattern', 'Lucene', true);
+      });
+      // filter actions should not exist for SQL
+      it('SQL', () => {
+        checkExpandedTableFilterActions('index_pattern', 'OpenSearch SQL', false);
+      });
+      // filter actions should not exist for PPL
+      it('PPL', () => {
+        checkExpandedTableFilterActions('index_pattern', 'PPL', false);
+      });
+    });
+    describe('index dataset', () => {
+      // filter actions should not exist for SQL
+      it('SQL', () => {
+        checkExpandedTableFilterActions('index', 'OpenSearch SQL', false);
+      });
+      // filter actions should not exist for PPL
+      it('PPL', () => {
+        checkExpandedTableFilterActions('index', 'OpenSearch SQL', false);
+      });
+    });
+  });
+});

cypress/support/e2e.js

@@ -3,4 +3,17 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-import '../utils/commands';
+import '../utils/commands.js';
+import '../utils/dashboards/data_explorer/commands.js';
+
+// Alternatively you can use CommonJS syntax:
+// require('./commands')
+
+const scopedHistoryNavigationError =
+  /^[^(ScopedHistory instance has fell out of navigation scope)]/;
+Cypress.on('uncaught:exception', (err) => {
+  /* returning false here prevents Cypress from failing the test */
+  if (scopedHistoryNavigationError.test(err.message)) {
+    return false;
+  }
+});

cypress/utils/commands.js

@@ -3,13 +3,95 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-// --- Typed commands --
+import {
+  MiscUtils,
+  LoginPage,
+} from '@opensearch-dashboards-test/opensearch-dashboards-test-library';
 
+const miscUtils = new MiscUtils(cy);
+const loginPage = new LoginPage(cy);
+
+/**
+ * Get DOM element by data-test-subj id.
+ */
 Cypress.Commands.add('getElementByTestId', (testId, options = {}) => {
   return cy.get(`[data-test-subj="${testId}"]`, options);
 });
 
+/**
+ * Get multiple DOM elements by data-test-subj ids.
+ */
 Cypress.Commands.add('getElementsByTestIds', (testIds, options = {}) => {
   const selectors = [testIds].flat(Infinity).map((testId) => `[data-test-subj="${testId}"]`);
   return cy.get(selectors.join(','), options);
 });
+
+/**
+ * Get DOM elements with a data-test-subj id containing the testId.
+ * @param testId data-test-subj value.
+ * @param options get options. Default: {}
+ * @example
+ * // returns all DOM elements that has a data-test-subj including the string 'table'
+ * cy.getElementsByTestIdLike('table')
+ */
+Cypress.Commands.add('getElementsByTestIdLike', (partialTestId, options = {}) => {
+  return cy.get(`[data-test-subj*="${partialTestId}"]`, options);
+});
+
+/**
+ * Find DOM elements with a data-test-subj id containing the testId.
+ * @param testId data-test-subj value.
+ * @param options get options. Default: {}
+ * @example
+ * // returns all DOM elements that has a data-test-subj including the string 'table'
+ * cy.findElementsByTestIdLike('table')
+ */
+Cypress.Commands.add(
+  'findElementsByTestIdLike',
+  { prevSubject: true },
+  (subject, partialTestId, options = {}) => {
+    return cy.wrap(subject).find(`[data-test-subj*="${partialTestId}"]`, options);
+  }
+);
+
+/**
+ * Find DOM element with a data-test-subj id containing the testId.
+ * @param testId data-test-subj value.
+ * @param options get options. Default: {}
+ * @example
+ * // returns all DOM elements that has a data-test-subj including the string 'table'
+ * cy.findElementsByTestIdLike('table')
+ */
+Cypress.Commands.add(
+  'findElementByTestId',
+  { prevSubject: true },
+  (subject, partialTestId, options = {}) => {
+    return cy.wrap(subject).find(`[data-test-subj="${partialTestId}"]`, options);
+  }
+);
+
+/**
+ * Find element from previous chained element by data-test-subj id.
+ */
+Cypress.Commands.add(
+  'findElementByTestId',
+  { prevSubject: true },
+  (subject, testId, options = {}) => {
+    return cy.wrap(subject).find(`[data-test-subj="${testId}"]`, options);
+  }
+);
+
+/**
+ * Go to the local instance of OSD's home page and login if needed.
+ */
+Cypress.Commands.add('localLogin', (username, password) => {
+  miscUtils.visitPage('/app/home');
+  cy.url().then(($url) => {
+    if ($url.includes('login')) {
+      loginPage.enterUserName(username);
+      loginPage.enterPassword(password);
+      loginPage.submit();
+    }
+    cy.url().should('contain', '/app/home');
+  });
+});