Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix saved search loading issue #9034

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

abbyhu2000
Copy link
Member

@abbyhu2000 abbyhu2000 commented Dec 11, 2024

Description

Fix the saved search loading issue in 2.17 when query enhancement is not enabled.

Issues Resolved

Screenshot

Screen.Recording.2024-12-10.at.4.14.11.PM.mov

Testing the changes

Changelog

  • fix: Fix saved search loading issue

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@abbyhu2000 abbyhu2000 added the discover for discover reinvent label Dec 11, 2024
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 60.79%. Comparing base (e9c9983) to head (7f7a649).
Report is 1 commits behind head on 2.17.

Files with missing lines Patch % Lines
...ic/application/view_components/utils/use_search.ts 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             2.17    #9034      +/-   ##
==========================================
- Coverage   60.79%   60.79%   -0.01%     
==========================================
  Files        3737     3737              
  Lines       88754    88761       +7     
  Branches    13804    13806       +2     
==========================================
+ Hits        53958    53959       +1     
- Misses      31480    31487       +7     
+ Partials     3316     3315       -1     
Flag Coverage Δ
Linux_1 28.75% <0.00%> (-0.01%) ⬇️
Linux_2 56.42% <ø> (ø)
Linux_3 37.70% <0.00%> (-0.01%) ⬇️
Linux_4 29.72% <ø> (+<0.01%) ⬆️
Windows_1 28.76% <0.00%> (-0.01%) ⬇️
Windows_2 56.37% <ø> (ø)
Windows_3 37.70% <0.00%> (-0.01%) ⬇️
Windows_4 29.72% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abbyhu2000 abbyhu2000 added the v2.17.1 Issues targeting release v2.17.1 label Dec 11, 2024
@AMoo-Miki AMoo-Miki merged commit d500ecb into opensearch-project:2.17 Dec 11, 2024
67 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discover for discover reinvent v2.17.1 Issues targeting release v2.17.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants