Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace] fix:Prevent user from visiting dashboards / visualizations when out of a workspace #9024

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Qxisylolo
Copy link
Contributor

Description

This pr addresses:

  1. Prevent user from visiting dashboards / visualizations when out of a workspace by setting WorkspaceAvailability

Issues Resolved

Screenshot

Testing the changes

Changelog

  • fix: Prevent user from visiting dashboards / visualizations when out of a workspace

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Qxisylolo <[email protected]>
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.86%. Comparing base (98e9042) to head (b8c77d4).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
src/plugins/workspace/public/plugin.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9024      +/-   ##
==========================================
+ Coverage   60.84%   60.86%   +0.01%     
==========================================
  Files        3808     3808              
  Lines       91183    91212      +29     
  Branches    14404    14411       +7     
==========================================
+ Hits        55480    55515      +35     
+ Misses      32163    32156       -7     
- Partials     3540     3541       +1     
Flag Coverage Δ
Linux_1 29.02% <33.33%> (-0.01%) ⬇️
Linux_2 56.38% <ø> (ø)
Linux_3 37.93% <ø> (+0.02%) ⬆️
Linux_4 29.01% <ø> (+0.02%) ⬆️
Windows_1 29.03% <33.33%> (-0.01%) ⬇️
Windows_2 56.34% <ø> (ø)
Windows_3 37.93% <ø> (+0.02%) ⬆️
Windows_4 29.01% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant