Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TESTID-140 sidebar first test suite #9021

Open
wants to merge 82 commits into
base: cypress-unification
Choose a base branch
from

update tests to cope with the helper message breaking them

aa289a9
Select commit
Loading
Failed to load commit list.
Open

TESTID-140 sidebar first test suite #9021

update tests to cope with the helper message breaking them
aa289a9
Select commit
Loading
Failed to load commit list.
DCO / DCO required action Dec 13, 2024 in 1s

DCO

There are 10 commits incorrectly signed off. This means that the author(s) of these commits failed to include a Signed-off-by line in their commit message.

To avoid having PRs blocked in the future, always include Signed-off-by: Author Name <[email protected]> in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

Here is how to fix the problem so that this code can be merged.


Rebase the branch

If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").

You should only do this if:

  • You are the only author of the commits in this branch
  • You are absolutely certain nobody else is doing any work based upon this branch
  • There are no empty commits in the branch (for example, a DCO Remediation Commit which was added using --allow-empty)

To add your Signed-off-by line to every commit in this branch:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~82 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin testid-140-sidebar

Summary

Commit sha: 6a0484a, Author: Argus Li, Committer: GitHub; Can not find "Argus Li [email protected]", in ["Daniel Rowe [email protected]", "Daniel Rowe [email protected]", "Daniel Rowe [email protected]", "Daniel Rowe [email protected]", "Daniel Rowe [email protected]", "Daniel Rowe [email protected]", "Daniel Rowe [email protected]", "Daniel Rowe [email protected]", "Daniel Rowe [email protected]", "Daniel Rowe [email protected]", "Daniel Rowe [email protected]", "Daniel Rowe [email protected]", "Argus Li [email protected]", "Daniel Rowe [email protected]", "Daniel Rowe [email protected]", "Argus Li [email protected]"].
Commit sha: 85273e3, Author: Brandon Shien, Committer: GitHub; Expected "Brandon Shien [email protected]", but got "Brandon Shien [email protected]".
Commit sha: 9f23442, Author: Federico Silva, Committer: GitHub; Expected "Federico Silva [email protected]", but got "Federico Silva [email protected]".
Commit sha: ba78349, Author: Federico Silva, Committer: Federico Silva; The sign-off is missing.
Commit sha: aa289a9, Author: Federico Silva, Committer: Federico Silva; The sign-off is missing.
Commit sha: c24d5bc, Author: Tianyu Gao, Committer: GitHub; Can not find "Tianyu Gao [email protected]", in ["tygao [email protected]", "tygao [email protected]", "tygao [email protected]", "tygao [email protected]"].
Commit sha: 98e9042, Author: Tyler Ohlsen, Committer: GitHub; The sign-off is missing.
Commit sha: b31206a, Author: yuboluo, Committer: GitHub; Can not find "yuboluo [email protected]", in ["yubonluo [email protected]", "yubonluo [email protected]", "yubonluo [email protected]", "yubonluo [email protected]", "yubonluo [email protected]", "yubonluo [email protected]", "yubonluo [email protected]", "yubonluo [email protected]", "yubonluo [email protected]"].
Commit sha: 340326f, Author: yuboluo, Committer: GitHub; Can not find "yuboluo [email protected]", in ["yubonluo [email protected]", "yubonluo [email protected]", "yubonluo [email protected]", "yubonluo [email protected]", "yubonluo [email protected]", "yubonluo [email protected]", "yubonluo [email protected]"].
Commit sha: 36bf5e8, Author: yuboluo, Committer: GitHub; Can not find "yuboluo [email protected]", in ["yubonluo [email protected]", "yubonluo [email protected]"].