fix: update the osd-plugin-generator template to reference the correct button #9014
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t button Signed-off-by: Justin Kim <[email protected]>
angle943
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
❌ Invalid Prefix For Manual Changeset CreationInvalid description prefix. Found "fix". Only "skip" entry option is permitted for manual commit of changeset files. If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description. |
Hailong-am
reviewed
Dec 6, 2024
Comment on lines
91
to
94
| <EuiButton type="primary" size="s" onClick={onClickHandler}> | ||
| <EuiSmallButton type="primary" size="s" onClick={onClickHandler}> | ||
| <FormattedMessage id="<%= camelCase(name) %>.buttonText" | ||
| defaultMessage="<%= hasServer ? 'Get data' : 'Click me' %>" /> | ||
| </EuiButton> | ||
| </EuiSmallButton> |
There was a problem hiding this comment.
can we fix the import by change EuiSmallButton to EuiButton, so the page style get unchanged.
There was a problem hiding this comment.
yes sure i will do that change
Signed-off-by: Justin Kim <[email protected]>
github-actions
bot
added
Skip-Changelog
Signed-off-by: Justin Kim <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9014 +/- ##
==========================================
- Coverage 60.87% 60.85% -0.02%
==========================================
Files 3808 3808
Lines 91189 91189
Branches 14405 14405
==========================================
- Hits 55510 55496 -14
- Misses 32139 32152 +13
- Partials 3540 3541 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ashwin-pc
approved these changes
Dec 6, 2024
joshuali925
approved these changes
Dec 6, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 6, 2024
…t button (#9014) * fix: update the osd-plugin-generator template to reference the correct button Signed-off-by: Justin Kim <[email protected]> * remove the size prop Signed-off-by: Justin Kim <[email protected]> * change it to EuiButton Signed-off-by: Justin Kim <[email protected]> --------- Signed-off-by: Justin Kim <[email protected]> (cherry picked from commit afb2605) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Hailong-am
pushed a commit
that referenced
this pull request
Dec 10, 2024
…t button (#9014) (#9018) * fix: update the osd-plugin-generator template to reference the correct button * remove the size prop * change it to EuiButton --------- (cherry picked from commit afb2605) Signed-off-by: Justin Kim <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
silva-qa
pushed a commit
to silva-qa/OpenSearch-Dashboards
that referenced
this pull request
Dec 12, 2024
…t button (opensearch-project#9014) * fix: update the osd-plugin-generator template to reference the correct button Signed-off-by: Justin Kim <[email protected]> * remove the size prop Signed-off-by: Justin Kim <[email protected]> * change it to EuiButton Signed-off-by: Justin Kim <[email protected]> --------- Signed-off-by: Justin Kim <[email protected]> Signed-off-by: Federico Silva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
fixes #8918
Testing the changes
node scripts/generate_plugin --name my_plugin_name -y, and upon navigating to my new plugin's page, the page correctly renders:Changelog
Check List
yarn test:jestyarn test:jest_integration