Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Query enhancements] use status 503 if search strategy throws 500 #9002

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport fe616e7 from #8876.

)

* [Query enhancements] use status 503 if opensearch throws 500

Signed-off-by: Joshua Li <[email protected]>

* update unit tests

Signed-off-by: Joshua Li <[email protected]>

---------

Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit fe616e7)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Dec 3, 2024

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

@github-actions github-actions bot added failed changeset and removed Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.87%. Comparing base (3b03179) to head (6e63ae5).
Report is 3 commits behind head on 2.x.

Files with missing lines Patch % Lines
.../plugins/query_enhancements/server/routes/index.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #9002      +/-   ##
==========================================
- Coverage   60.91%   60.87%   -0.05%     
==========================================
  Files        3801     3807       +6     
  Lines       91050    91156     +106     
  Branches    14366    14392      +26     
==========================================
+ Hits        55459    55487      +28     
- Misses      32065    32142      +77     
- Partials     3526     3527       +1     
Flag Coverage Δ
Linux_1 29.04% <ø> (ø)
Linux_2 56.52% <ø> (ø)
Linux_3 37.83% <ø> (+<0.01%) ⬆️
Linux_4 29.99% <75.00%> (-0.02%) ⬇️
Windows_1 29.06% <ø> (ø)
Windows_2 56.48% <ø> (ø)
Windows_3 37.83% <ø> (ø)
Windows_4 29.99% <75.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshuali925 joshuali925 merged commit eaadd99 into 2.x Dec 5, 2024
71 of 75 checks passed
@github-actions github-actions bot deleted the backport/backport-8876-to-2.x branch December 5, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
all-star-contributor autocut Skip the changelog verification check on backports discover for discover reinvent discover-next failed changeset v2.19.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants