Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[discover] data type overrides language config and if includes time filter then don't modify query #8917

Closed

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Nov 23, 2024

Description

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Kawika Avilla <[email protected]>
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 6 lines in your changes missing coverage. Please review.

Project coverage is 60.87%. Comparing base (f110637) to head (68fc176).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ta/public/ui/query_editor/query_editor_top_row.tsx 60.00% 1 Missing and 3 partials ⚠️
...s/data/public/ui/dataset_selector/configurator.tsx 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8917   +/-   ##
=======================================
  Coverage   60.87%   60.87%           
=======================================
  Files        3802     3802           
  Lines       91060    91083   +23     
  Branches    14370    14377    +7     
=======================================
+ Hits        55437    55451   +14     
- Misses      32084    32088    +4     
- Partials     3539     3544    +5     
Flag Coverage Δ
Linux_1 29.01% <0.00%> (+<0.01%) ⬆️
Linux_2 56.39% <ø> (ø)
Linux_3 37.90% <66.66%> (+<0.01%) ⬆️
Linux_4 28.99% <0.00%> (-0.01%) ⬇️
Windows_1 29.03% <0.00%> (+<0.01%) ⬆️
Windows_2 56.34% <ø> (ø)
Windows_3 37.90% <66.66%> (+<0.01%) ⬆️
Windows_4 28.99% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
if (datasetTypeConfig?.getSearchOptions?.().includeTimeFilter) {
request.params = {
...request.params,
body: {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be accessible in the search strategy like

request.body.timeRange;

Signed-off-by: Kawika Avilla <[email protected]>
@kavilla kavilla changed the title datepicker conditional render [discover] data type overrides language config and if includes time filter then don't modify query Nov 23, 2024
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@joshuali925
Copy link
Member

will continue in #8932

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants