-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix toggle column action in the discover page #8905
Fix toggle column action in the discover page #8905
Conversation
ℹ️ Manual Changeset Creation ReminderPlease ensure manual commit for changeset file 8905.yml under folder changelogs/fragments to complete this PR. If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link. For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool. |
Signed-off-by: Tony Lee <[email protected]>
Signed-off-by: Tony Lee <[email protected]>
c72b308
to
bf4cc6e
Compare
@abbyhu2000 Would you kindly help with the WhiteSource Security Check fail in this PR? Any required action on my side? Is there a way to re-run the checks? Thank you! 🙏 |
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Signed-off-by: Tony Lee <[email protected]>
let me re-run the check and see if it passes~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! Thanks for the unit test
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8905 +/- ##
==========================================
- Coverage 60.87% 60.84% -0.04%
==========================================
Files 3808 3808
Lines 91209 91209
Branches 14410 14410
==========================================
- Hits 55526 55492 -34
- Misses 32142 32222 +80
+ Partials 3541 3495 -46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
src/plugins/discover/public/application/components/doc_viewer/doc_viewer_tab.test.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Tony Lee <[email protected]>
@abbyhu2000 I am not sure how to trigger the WhiteSource Security Check from my side. Could you help review and trigger the check? or let me know what I can do to trigger, thank you for your help! |
@abbyhu2000 @sejli Would you kindly help look after this PR? Please do let me know if there's more changes/actions needed to get this PR merged. Thank you very much for your help! 🙏 |
@abbyhu2000 @sejli @AMoo-Miki Just want to follow up with the PR review request. Please let me know the general process of working with the maintainer on merging a PR. I really appreciate your support!! |
Thanks @tungsheng for moving this PR forward for review with OpenSearch Dashboards team. We will also like to have it part of next OpenSearch Dashboards release as it is impacting critical customer workflow. It will be good to have it back-ported to 2.x branch. |
* Update DocViewerTab if columns is changed * Add unit test for DocViewerTab prop 'columns' changed * Add changeset file * Changeset file for PR #8905 created/updated * Use the new license header --------- Signed-off-by: Tony Lee <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Miki <[email protected]> (cherry picked from commit faa6b54) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
The
DocViewerTab
component needs to be updated when thecolumns
prop is updated.This PR
columns
prop check in theshouldComponentUpdate
lifecycle method.columns
prop changed.Issues Resolved
fixes
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration