Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual Backport 2.x] Upgrade actions/upload-artifact to v4 #8892

Open
wants to merge 4 commits into
base: 2.x
Choose a base branch
from
+16 −14
Open

[Manual Backport 2.x] Upgrade actions/upload-artifact to v4 #8892

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d55c502
[chore]upgrade actions/upload-artifact to v4 (#8855)
Hailong-am Nov 19, 2024
0d2380f
fix merge issue
Hailong-am Nov 19, 2024
351be20
Merge branch '2.x' into backport/backport-8855-to-2.x
Hailong-am Nov 21, 2024
505633d
Merge branch '2.x' into backport/backport-8855-to-2.x
Hailong-am Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/build_and_test_workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ jobs:
JOB: ci${{ matrix.group }}
CACHE_DIR: ciGroup${{ matrix.group }}

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
if: failure()
with:
name: failure-artifacts-ci${{ matrix.group }}
Expand Down Expand Up @@ -393,7 +393,7 @@ jobs:
id: plugin-ftr-tests
run: node scripts/functional_tests.js --config test/plugin_functional/config.ts

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
if: failure()
with:
name: failure-artifacts-plugin-functional-${{ matrix.os }}
Expand Down Expand Up @@ -506,7 +506,7 @@ jobs:
- name: Build `${{ matrix.name }}`
run: yarn ${{ matrix.script }} --release

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
if: success()
with:
name: ${{ matrix.suffix }}-${{ env.VERSION }}
Expand Down Expand Up @@ -583,7 +583,7 @@ jobs:
run: |
yarn test:bwc -s false -o ${{ env.OPENSEARCH_URL }} -d ${{ steps.download.outputs.download-path }}/opensearch-dashboards-${{ env.VERSION }}-linux-x64.tar.gz -v ${{ matrix.version }}

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
if: ${{ failure() && steps.verify-opensearch-exists.outputs.version-exists == 'true' }}
with:
name: ${{ matrix.version }}-test-failures
Expand Down
16 changes: 8 additions & 8 deletions .github/workflows/cypress_workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,24 +152,24 @@ jobs:
command: yarn cypress:run-without-security --browser ${{ env.CYPRESS_BROWSER }} --spec ${{ env.SPEC }}

# Screenshots are only captured on failure, will change this once we do visual regression tests
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
if: failure()
with:
name: ftr-cypress-screenshots
name: ftr-cypress-screenshots-${{ matrix.group }}
path: ${{ env.FTR_PATH }}/cypress/screenshots
retention-days: 1
- uses: actions/upload-artifact@v3

- uses: actions/upload-artifact@v4
if: always()
with:
name: ftr-cypress-videos
name: ftr-cypress-videos-${{ matrix.group }}
path: ${{ env.FTR_PATH }}/cypress/videos
retention-days: 1

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
if: always()
with:
name: ftr-cypress-results
name: ftr-cypress-results-${{ matrix.group }}
path: ${{ env.FTR_PATH }}/cypress/results
retention-days: 1

Expand Down Expand Up @@ -207,6 +207,6 @@ jobs:
'${{ env.SPEC }}'
```

#### Link to results:
#### Link to results:
${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
edit-mode: replace
2 changes: 2 additions & 0 deletions changelogs/fragments/8855.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
fix:
- Upgrade actions/upload-artifact to v4 ([#8855](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/8855))
Loading