[Workspace][Bug] Fix inspect page url error #8857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yubonluo <[email protected]>
yubonluo
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8857 +/- ##
==========================================
- Coverage 60.86% 56.39% -4.48%
==========================================
Files 3800 1239 -2561
Lines 90818 25913 -64905
Branches 14307 4437 -9870
==========================================
- Hits 55276 14613 -40663
+ Misses 32028 10559 -21469
+ Partials 3514 741 -2773
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hailong-am
reviewed
Nov 13, 2024
Comment on lines
-28
to
+31
| finalEditUrl = finalEditUrl.replace(/^\/management\/opensearch-dashboards/, '/app'); | ||
| finalEditUrl = finalEditUrl.replace(/^\/management\/opensearch-dashboards/, ''); | ||
| } | ||
| if (finalEditUrl) { | ||
| finalEditUrl = `/app${finalEditUrl}`; |
There was a problem hiding this comment.
is there a reason to do this?
There was a problem hiding this comment.
In any case, need to add the \app prefix to the url, otherwise user will not be able to access it. According to previous practice, when new home is closed, the URL will miss the \app prefix
SuZhou-Joe
approved these changes
Nov 13, 2024
Hailong-am
approved these changes
Nov 14, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
* Fix inspect page url error Signed-off-by: yubonluo <[email protected]> * Changeset file for PR #8857 created/updated --------- Signed-off-by: yubonluo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 66ea096) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
After solving the issue 1, clicking inspect button will go to the inspect page
After solving the issue 2, clicking inspect button in the relationship will go to the workspace inspect page.
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration