Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Decouple data$ updates to prevent rows clearing on hook re-render #8806

Merged
merged 6 commits into from
Nov 7, 2024

fix flaky unit tests

9dd86ac
Select commit
Loading
Failed to load commit list.
Merged

[Discover] Decouple data$ updates to prevent rows clearing on hook re-render #8806

fix flaky unit tests
9dd86ac
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 7, 2024 in 0s

60.87% (+0.08%) compared to 78204a0

View this Pull Request on Codecov

60.87% (+0.08%) compared to 78204a0

Details

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.87%. Comparing base (78204a0) to head (9dd86ac).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...public/query/timefilter/timefilter_service.mock.ts 66.66% 1 Missing ⚠️
...ic/application/view_components/utils/use_search.ts 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8806      +/-   ##
==========================================
+ Coverage   60.78%   60.87%   +0.08%     
==========================================
  Files        3798     3799       +1     
  Lines       90701    90761      +60     
  Branches    14284    14294      +10     
==========================================
+ Hits        55135    55248     +113     
+ Misses      32067    32004      -63     
- Partials     3499     3509      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov