[ciGroup6 fix] add data-test-subj for refresh data button in discover #8782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anan Zhuang <[email protected]>
ananzh
requested review from
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
github-actions
bot
added
the
Skip-Changelog
ananzh
removed
the
Skip-Changelog
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8782 +/- ##
==========================================
+ Coverage 60.75% 60.77% +0.01%
==========================================
Files 3798 3798
Lines 90690 90690
Branches 14277 14277
==========================================
+ Hits 55101 55115 +14
+ Misses 32090 32076 -14
Partials 3499 3499
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Merged
1 task
1 task
ashwin-pc
approved these changes
Nov 4, 2024
abbyhu2000
approved these changes
Nov 4, 2024
ruanyl
approved these changes
Nov 5, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 5, 2024
Signed-off-by: Anan Zhuang <[email protected]> (cherry picked from commit 758e4fb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Hailong-am
pushed a commit
that referenced
this pull request
Nov 7, 2024
(cherry picked from commit 758e4fb) Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ciGroup6 sometimes failed to find refresh data button though this element is on DOM.
I tried a different way to find the element opensearch-project/opensearch-dashboards-functional-test#1615 but seems still flaky. Among 3 times running, see 1 failure and 2 success. Seems the ultimate robust way to fix it is to add
data-test-subj. I also test 3 times, all success.Issues Resolved
NA
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration