Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert back to using the official release of vega-interpreter #8744

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

AMoo-Miki
Copy link
Collaborator

@AMoo-Miki AMoo-Miki commented Oct 29, 2024

Description

Revert back to using the official release of vega-interpreter
Note: Our PR was merged into their 1.0.5 release so we can stop using the patched version.

Changelog

  • chore: Revert back to using the official release of vega-interpreter

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.76%. Comparing base (c66b698) to head (fdfdbcf).
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8744      +/-   ##
==========================================
+ Coverage   60.75%   60.76%   +0.01%     
==========================================
  Files        3798     3798              
  Lines       90682    90682              
  Branches    14271    14271              
==========================================
+ Hits        55092    55102      +10     
+ Misses      32093    32082      -11     
- Partials     3497     3498       +1     
Flag Coverage Δ
Linux_1 29.06% <ø> (ø)
Linux_2 56.39% <ø> (ø)
Linux_3 37.60% <ø> (-0.01%) ⬇️
Linux_4 29.82% <ø> (ø)
Windows_1 29.09% <ø> (+0.01%) ⬆️
Windows_2 56.34% <ø> (ø)
Windows_3 37.60% <ø> (ø)
Windows_4 29.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ananzh ananzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@AMoo-Miki AMoo-Miki merged commit 78204a0 into opensearch-project:main Nov 4, 2024
72 of 73 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-8744-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 78204a09479b72603034b5a6cda309e02bf98e57
# Push it to GitHub
git push --set-upstream origin backport/backport-8744-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-8744-to-2.x.

AMoo-Miki added a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Nov 19, 2024
…search-project#8744)

* Revert back to using the official release of `vega-interpreter`

Signed-off-by: Miki <[email protected]>

* Changeset file for PR opensearch-project#8744 created/updated

---------

Signed-off-by: Miki <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

(cherry picked from commit 78204a0)
Signed-off-by: Miki <[email protected]>
ruanyl pushed a commit that referenced this pull request Dec 4, 2024
* Revert back to using the official release of `vega-interpreter` (#8744)

* Revert back to using the official release of `vega-interpreter`

Signed-off-by: Miki <[email protected]>

* Changeset file for PR #8744 created/updated

---------

Signed-off-by: Miki <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

(cherry picked from commit 78204a0)
Signed-off-by: Miki <[email protected]>

* [CVE-2024-21538] Bump `cross-spawn` from 6.0.5 and 7.0.3 to 7.0.5 (#8882)

* Bump `cross-spawn` from 6.0.5 and 7.0.3 to 7.0.5

Signed-off-by: Miki <[email protected]>

* Changeset file for PR #8882 created/updated

---------

Signed-off-by: Miki <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

(cherry picked from commit d94fad2)
Signed-off-by: Miki <[email protected]>

---------

Signed-off-by: Miki <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants