-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub workflow cypress #8684
Add GitHub workflow cypress #8684
Conversation
changelogs/fragments/8682.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we have a fragment from another PR here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Although im not the expert on the CI group matrix code so would be nice for someone who's familiar with that to also look at it. @kavilla perhaps?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8684 +/- ##
=======================================
Coverage 60.84% 60.84%
=======================================
Files 3793 3793
Lines 90486 90486
Branches 14212 14212
=======================================
+ Hits 55055 55057 +2
+ Misses 31940 31939 -1
+ Partials 3491 3490 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: abbyhu2000 <[email protected]>
e03411e
to
643c5d3
Compare
Signed-off-by: Anan Zhuang <[email protected]>
@@ -49,7 +51,7 @@ jobs: | |||
strategy: | |||
fail-fast: false | |||
matrix: | |||
group: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10] | |||
group: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you link FTR repo change for ci-group 11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi this PR is old, i have a new PR #8703 for the changes.
this PR is closed, changes are tracked in a new PR: #8703 |
Description
Add CiGroup 11 to github workflow for cypress tests of discover 2.0
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration