Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub workflow cypress #8684

Conversation

abbyhu2000
Copy link
Member

Description

Add CiGroup 11 to github workflow for cypress tests of discover 2.0

Issues Resolved

Screenshot

Testing the changes

Changelog

  • feat: Add cypress test workflow for discover 2.0

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have a fragment from another PR here?

ashwin-pc
ashwin-pc previously approved these changes Oct 23, 2024
Copy link
Member

@ashwin-pc ashwin-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Although im not the expert on the CI group matrix code so would be nice for someone who's familiar with that to also look at it. @kavilla perhaps?

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.84%. Comparing base (e4281e4) to head (e1f24ce).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8684   +/-   ##
=======================================
  Coverage   60.84%   60.84%           
=======================================
  Files        3793     3793           
  Lines       90486    90486           
  Branches    14212    14212           
=======================================
+ Hits        55055    55057    +2     
+ Misses      31940    31939    -1     
+ Partials     3491     3490    -1     
Flag Coverage Δ
Linux_1 29.07% <ø> (ø)
Linux_2 56.39% <ø> (ø)
Linux_3 37.67% <ø> (?)
Linux_4 29.84% <ø> (ø)
Windows_1 29.08% <ø> (ø)
Windows_2 56.35% <ø> (ø)
Windows_3 37.67% <ø> (ø)
Windows_4 29.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abbyhu2000 abbyhu2000 force-pushed the add_github_workflow_cypress branch from e03411e to 643c5d3 Compare October 23, 2024 20:35
@@ -49,7 +51,7 @@ jobs:
strategy:
fail-fast: false
matrix:
group: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
group: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you link FTR repo change for ci-group 11

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi this PR is old, i have a new PR #8703 for the changes.

@abbyhu2000
Copy link
Member Author

this PR is closed, changes are tracked in a new PR: #8703

@abbyhu2000 abbyhu2000 closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants