Fix data source info is missing in default query when click Discover from other pages #8583
Conversation
gaobinlong
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
ℹ️ Manual Changeset Creation ReminderPlease ensure manual commit for changeset file 8583.yml under folder changelogs/fragments to complete this PR. If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link. For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool. |
Signed-off-by: Gao Binlong <[email protected]> Add changelog Signed-off-by: gaobinlong <[email protected]> Modify changelog Signed-off-by: gaobinlong <[email protected]>
gaobinlong
force-pushed
the
fix_default_query
branch
from
6679fbd to
4d3a879
Compare
|
@SuZhou-Joe @ruanyl could you help to review this PR, thank you! |
src/plugins/data/public/query/query_string/dataset_service/dataset_service.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: gaobinlong <[email protected]>
Signed-off-by: gaobinlong <[email protected]>
|
@gaobinlong we have merged ina few fixes since you raised this PR. IS this still needed? |
@ashwin-pc I've tested the newest main branch, the issue still exists, so this PR is still needed. |
ashwin-pc
added
discover
|
@gaobinlong Im not able to reproduce the issue originally linked in the PR. I do see the daatsource name missing, but the data itself is correct. Is that what you are seeing as well? |
|
Great catch! Thank you @gaobinlong, going to merge in. Any feedback on the current dataset type config? Was it straight forward? Or any issues you had while implementing. |
…from other pages (#8583) When we click Discover sidebar from other pages, we don't fetch the data source info and enrich the default dataset, so that some unexpected behavior happens. Issues Resolved #8582 Signed-off-by: gaobinlong <[email protected]> (cherry picked from commit 97f4734) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…from other pages (#8583) When we click Discover sidebar from other pages, we don't fetch the data source info and enrich the default dataset, so that some unexpected behavior happens. Issues Resolved #8582 Signed-off-by: gaobinlong <[email protected]> (cherry picked from commit 97f4734) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
One thing to note: recent datasets could be stale so best way to recreate the original issue was to start in a fresh session set a default index to point to a remote cluster then navigate to Discover |
…from other pages (#8583) (#8793) When we click Discover sidebar from other pages, we don't fetch the data source info and enrich the default dataset, so that some unexpected behavior happens. Issues Resolved #8582 (cherry picked from commit 97f4734) Signed-off-by: gaobinlong <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…from other pages (#8583) (#8794) When we click Discover sidebar from other pages, we don't fetch the data source info and enrich the default dataset, so that some unexpected behavior happens. Issues Resolved #8582 (cherry picked from commit 97f4734) Signed-off-by: gaobinlong <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
When we click Discover sidebar from other pages, we don't fetch the data source info and enrich the default dataset, so that some unexpected behavior happens.
Issues Resolved
#8582
Screenshot
No UI change.
The direct impact is that when click
Discoverfrom other pages, the selected default dataset always shows the data source prefix, and makes other components work.Testing the changes
Discoverfrom other pages, check if the selected dataset shows the data source prefix, and also check if the url contains data source info.Changelog
Check List
yarn test:jestyarn test:jest_integration