Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data Explorer][Discover 2.0] Allow Top Nav to update based on index pattern change #4889

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Aug 31, 2023

Issues Resolved

#4888

Screenshot 2023-08-31 at 15 17 11

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #4889 (d20b30d) into main (9d7f576) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4889   +/-   ##
=======================================
  Coverage   66.39%   66.39%           
=======================================
  Files        3397     3397           
  Lines       64804    64804           
  Branches    10360    10360           
=======================================
+ Hits        43026    43028    +2     
+ Misses      19218    19216    -2     
  Partials     2560     2560           
Flag Coverage Δ
Linux_1 34.85% <ø> (ø)
Linux_2 55.15% <ø> (ø)
Linux_3 44.23% <ø> (ø)
Linux_4 34.92% <ø> (+<0.01%) ⬆️
Windows_1 34.87% <ø> (ø)
Windows_2 55.12% <ø> (ø)
Windows_3 44.24% <ø> (ø)
Windows_4 34.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@ashwin-pc ashwin-pc added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Aug 31, 2023
@ashwin-pc ashwin-pc merged commit c886b00 into opensearch-project:main Sep 1, 2023
65 of 84 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 1, 2023
…pattern change (#4889)

Issue Resolve
#4888

Signed-off-by: ananzh <[email protected]>
(cherry picked from commit c886b00)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshuarrrr pushed a commit that referenced this pull request Sep 1, 2023
…pattern change (#4889) (#4899)

Issue Resolve
#4888


(cherry picked from commit c886b00)

Signed-off-by: ananzh <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x data explorer Issues related to the Data Explorer project discover for discover reinvent distinguished-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.10.0
Projects
Status: 2.10.0 (Launched)
Development

Successfully merging this pull request may close these issues.

3 participants