[Data Explorer][Discover 2.0] Allow Top Nav to update based on index pattern change #4889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pattern change Issue Resolve opensearch-project#4888 Signed-off-by: ananzh <[email protected]>
ananzh
requested review from
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy and
curq
as code owners
ananzh
added
discover
Codecov Report
@@ Coverage Diff @@
## main #4889 +/- ##
=======================================
Coverage 66.39% 66.39%
=======================================
Files 3397 3397
Lines 64804 64804
Branches 10360 10360
=======================================
+ Hits 43026 43028 +2
+ Misses 19218 19216 -2
Partials 2560 2560
Flags with carried forward coverage won't be shown. Click here to find out more. |
ashwin-pc
added
the
Skip-Changelog
AMoo-Miki
approved these changes
Sep 1, 2023
ashwin-pc
approved these changes
Sep 1, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 1, 2023
…pattern change (#4889) Issue Resolve #4888 Signed-off-by: ananzh <[email protected]> (cherry picked from commit c886b00) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshuarrrr
pushed a commit
that referenced
this pull request
Sep 1, 2023
…pattern change (#4889) (#4899) Issue Resolve #4888 (cherry picked from commit c886b00) Signed-off-by: ananzh <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues Resolved
#4888
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr