[Next theme] Add modal to notify users of theme updates #4715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy and images provisional, for demo purposes only. Signed-off-by: Josh Romero <[email protected]>
Signed-off-by: Josh Romero <[email protected]>
joshuarrrr
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub and
BSFishy
as code owners
Codecov Report
@@ Coverage Diff @@
## main #4715 +/- ##
==========================================
- Coverage 66.46% 66.46% -0.01%
==========================================
Files 3390 3391 +1
Lines 64742 64753 +11
Branches 10312 10312
==========================================
+ Hits 43030 43036 +6
- Misses 19169 19174 +5
Partials 2543 2543
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Josh Romero <[email protected]>
Signed-off-by: Josh Romero <[email protected]>
Signed-off-by: Josh Romero <[email protected]>
joshuarrrr
changed the title
Signed-off-by: Josh Romero <[email protected]>
|
WIP demo of this PR + #4845 + additional changes |
|
@joshuarrrr marking this as draft until its ready for review. Feel free to unmark it if thats not correct. |
and hide modal if v7 theme is in use Signed-off-by: Josh Romero <[email protected]>
Signed-off-by: Josh Romero <[email protected]>
…Search-Dashboards into feat/next-preview-notify
AMoo-Miki
reviewed
Aug 30, 2023
| <EuiText> | ||
| <FormattedMessage | ||
| id="home.newThemeModal.previewDescription.previewDetail" | ||
| defaultMessage="You are now previewing the newest OpenSearch Dashboards theme with improved light and dark |
There was a problem hiding this comment.
"newest" sounds odd to me; it reads as "previewing the latest new theme". why not just "latest" or just "new"?
AMoo-Miki
approved these changes
Aug 30, 2023
ashwin-pc
approved these changes
Aug 31, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 31, 2023
* Feat (home): Add modal to introduce `next` theme changes Copy and images provisional, for demo purposes only. Signed-off-by: Josh Romero <[email protected]> * revert unintended config change Signed-off-by: Josh Romero <[email protected]> * add changelog Signed-off-by: Josh Romero <[email protected]> * Disable new theme modal for functional tests Signed-off-by: Josh Romero <[email protected]> * add deep link to settings and hide modal if v7 theme is in use Signed-off-by: Josh Romero <[email protected]> * add unit tests and fix imports Signed-off-by: Josh Romero <[email protected]> --------- Signed-off-by: Josh Romero <[email protected]> (cherry picked from commit b846e80) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
kavilla
pushed a commit
that referenced
this pull request
Sep 1, 2023
* Feat (home): Add modal to introduce `next` theme changes Copy and images provisional, for demo purposes only. Signed-off-by: Josh Romero <[email protected]> * revert unintended config change Signed-off-by: Josh Romero <[email protected]> * add changelog Signed-off-by: Josh Romero <[email protected]> * Disable new theme modal for functional tests Signed-off-by: Josh Romero <[email protected]> * add deep link to settings and hide modal if v7 theme is in use Signed-off-by: Josh Romero <[email protected]> * add unit tests and fix imports Signed-off-by: Josh Romero <[email protected]> --------- Signed-off-by: Josh Romero <[email protected]> (cherry picked from commit b846e80) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Copy and images provisional, for demo purposes only.
Add a new modal to the home page that provides explanation of theme changes and a link to advanced settings where themes can be managed.
On close or dismissal, set a
localstoragevalue that will hide the modal on future visits tohome.Also provide a config value that can be used to permanently disable the modal.
Issues Resolved
fixes #4676
Screenshot
Testing the changes
homeor first loading the applicationCheck List
yarn test:jestyarn test:jest_integrationyarn test:ftr