fix flaky unit tests

Signed-off-by: Joshua Li <[email protected]>
opensearch-project · Nov 7, 2024 · 9dd86ac · 9dd86ac
1 parent fc4d91f
commit 9dd86ac
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 6 deletions.
diff --git a/src/plugins/data/public/query/timefilter/timefilter_service.mock.ts b/src/plugins/data/public/query/timefilter/timefilter_service.mock.ts
@@ -38,10 +38,10 @@ const createSetupContractMock = () => {
     isAutoRefreshSelectorEnabled: jest.fn(),
     isTimeRangeSelectorEnabled: jest.fn(),
     getEnabledUpdated$: jest.fn(),
-    getTimeUpdate$: jest.fn(),
-    getRefreshIntervalUpdate$: jest.fn(),
+    getTimeUpdate$: jest.fn(() => new Observable<unknown>()),
+    getRefreshIntervalUpdate$: jest.fn(() => new Observable<unknown>()),
     getAutoRefreshFetch$: jest.fn(() => new Observable<unknown>()),
-    getFetch$: jest.fn(),
+    getFetch$: jest.fn(() => new Observable<unknown>()),
     getTime: jest.fn(),
     setTime: jest.fn(),
     setRefreshInterval: jest.fn(),

diff --git a/src/plugins/discover/public/application/view_components/utils/use_search.test.tsx b/src/plugins/discover/public/application/view_components/utils/use_search.test.tsx
@@ -79,11 +79,17 @@ describe('useSearch', () => {
     const services = createMockServices();
     (services.uiSettings.get as jest.Mock).mockReturnValueOnce(true);
 
-    const { result } = renderHook(() => useSearch(services), { wrapper });
+    const { result, waitForNextUpdate } = renderHook(() => useSearch(services), { wrapper });
 
     expect(result.current.data$.getValue()).toEqual(
       expect.objectContaining({ status: ResultStatus.LOADING })
     );
+
+    // useSearch updates state async in useEffect, wait for it to finish to
+    // avoid warning
+    await act(async () => {
+      await waitForNextUpdate();
+    });
   });
 
   it('should initialize with uninitialized state when search on page load is disabled', async () => {
@@ -94,16 +100,20 @@ describe('useSearch', () => {
       value: 10,
     });
 
-    const { result } = renderHook(() => useSearch(services), { wrapper });
+    const { result, waitForNextUpdate } = renderHook(() => useSearch(services), { wrapper });
     expect(result.current.data$.getValue()).toEqual(
       expect.objectContaining({ status: ResultStatus.UNINITIALIZED })
     );
+
+    await act(async () => {
+      await waitForNextUpdate();
+    });
   });
 
   it('should update startTime when hook rerenders', async () => {
     const services = createMockServices();
 
-    const { result, rerender } = renderHook(() => useSearch(services), {
+    const { result, rerender, waitForNextUpdate } = renderHook(() => useSearch(services), {
       wrapper,
     });
 
@@ -114,6 +124,10 @@ describe('useSearch', () => {
     const newStartTime = result.current.data$.getValue().queryStatus?.startTime;
     expect(newStartTime).toBeDefined();
     expect(newStartTime).not.toEqual(initialStartTime);
+
+    await act(async () => {
+      await waitForNextUpdate();
+    });
   });
 
   it('should reset data observable when dataset changes', async () => {