[Workspace] Clear the attribute of error objects (#9003)

* clear the attribute of error objects Signed-off-by: yubonluo <[email protected]> * Changeset file for PR #9003 created/updated * Changeset file for PR #9003 deleted --------- Signed-off-by: yubonluo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
opensearch-project · Dec 5, 2024 · 36bf5e8 · 36bf5e8
1 parent 98e9042
commit 36bf5e8
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 23 deletions.
diff --git a/...ns/workspace/server/saved_objects/integration_tests/workspace_id_consumer_wrapper.test.ts b/...ns/workspace/server/saved_objects/integration_tests/workspace_id_consumer_wrapper.test.ts
@@ -485,9 +485,7 @@ describe('workspace_id_consumer integration test', () => {
       ]);
       expect(bulkGetResultWithWorkspace.body.saved_objects[0]?.error).toBeUndefined();
       expect(bulkGetResultWithWorkspace.body.saved_objects[1].id).toEqual('bar');
-      expect(bulkGetResultWithWorkspace.body.saved_objects[1].workspaces).toEqual([
-        createdBarWorkspace.id,
-      ]);
+      expect(bulkGetResultWithWorkspace.body.saved_objects[1].workspaces).toBeUndefined();
       expect(bulkGetResultWithWorkspace.body.saved_objects[1]?.error).toMatchInlineSnapshot(`
         Object {
           "error": "Forbidden",

diff --git a/src/plugins/workspace/server/saved_objects/workspace_id_consumer_wrapper.test.ts b/src/plugins/workspace/server/saved_objects/workspace_id_consumer_wrapper.test.ts
@@ -432,8 +432,8 @@ describe('WorkspaceIdConsumerWrapper', () => {
       {
         type: 'dashboard',
         id: 'dashboard_id',
-        attributes: {},
-        references: [],
+        attributes: { description: 'description' },
+        references: ['reference_id'],
         workspaces: ['foo'],
       },
       {
@@ -450,8 +450,8 @@ describe('WorkspaceIdConsumerWrapper', () => {
       {
         type: 'visualization',
         id: 'visualization_id',
-        attributes: {},
-        references: [],
+        attributes: { description: 'description' },
+        references: ['reference_id'],
         workspaces: ['bar'],
       },
       {
@@ -493,9 +493,13 @@ describe('WorkspaceIdConsumerWrapper', () => {
         Object {
           "saved_objects": Array [
             Object {
-              "attributes": Object {},
+              "attributes": Object {
+                "description": "description",
+              },
               "id": "dashboard_id",
-              "references": Array [],
+              "references": Array [
+                "reference_id",
+              ],
               "type": "dashboard",
               "workspaces": Array [
                 "foo",
@@ -522,9 +526,6 @@ describe('WorkspaceIdConsumerWrapper', () => {
               "id": "visualization_id",
               "references": Array [],
               "type": "visualization",
-              "workspaces": Array [
-                "bar",
-              ],
             },
             Object {
               "attributes": Object {},
@@ -571,9 +572,13 @@ describe('WorkspaceIdConsumerWrapper', () => {
         Object {
           "saved_objects": Array [
             Object {
-              "attributes": Object {},
+              "attributes": Object {
+                "description": "description",
+              },
               "id": "dashboard_id",
-              "references": Array [],
+              "references": Array [
+                "reference_id",
+              ],
               "type": "dashboard",
               "workspaces": Array [
                 "foo",
@@ -600,9 +605,6 @@ describe('WorkspaceIdConsumerWrapper', () => {
               "id": "visualization_id",
               "references": Array [],
               "type": "visualization",
-              "workspaces": Array [
-                "bar",
-              ],
             },
             Object {
               "attributes": Object {},
@@ -688,9 +690,13 @@ describe('WorkspaceIdConsumerWrapper', () => {
         Object {
           "saved_objects": Array [
             Object {
-              "attributes": Object {},
+              "attributes": Object {
+                "description": "description",
+              },
               "id": "dashboard_id",
-              "references": Array [],
+              "references": Array [
+                "reference_id",
+              ],
               "type": "dashboard",
               "workspaces": Array [
                 "foo",
@@ -717,9 +723,6 @@ describe('WorkspaceIdConsumerWrapper', () => {
               "id": "visualization_id",
               "references": Array [],
               "type": "visualization",
-              "workspaces": Array [
-                "bar",
-              ],
             },
             Object {
               "attributes": Object {},

diff --git a/src/plugins/workspace/server/saved_objects/workspace_id_consumer_wrapper.ts b/src/plugins/workspace/server/saved_objects/workspace_id_consumer_wrapper.ts
@@ -195,7 +195,10 @@ export class WorkspaceIdConsumerWrapper {
               return this.validateObjectInAWorkspace(object, workspaces[0], wrapperOptions.request)
                 ? object
                 : {
-                    ...object,
+                    id: object.id,
+                    type: object.type,
+                    attributes: {} as T,
+                    references: [],
                     error: {
                       ...generateSavedObjectsForbiddenError().output.payload,
                     },