Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to copier template #85

Merged
merged 61 commits into from
Jan 22, 2024
Merged

Switch to copier template #85

merged 61 commits into from
Jan 22, 2024

Conversation

znicholls
Copy link
Collaborator

  • entry added in changelog

@maritsandstad
Copy link
Collaborator

I can try to clean up the ciceroscm pandas< 2 issue @znicholls, if that's helpful (probably about time anyway)...

@znicholls
Copy link
Collaborator Author

znicholls commented Jan 19, 2024 via email

Copy link

codecov bot commented Jan 19, 2024

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@maritsandstad
Copy link
Collaborator

Great, I'll wait for a ping, then :-)

@znicholls znicholls requested a review from lewisjared January 19, 2024 16:54
@znicholls
Copy link
Collaborator Author

@lewisjared not really sure if review can do anything meaningful but just as an FYI. Docs build based on notebooks and have runtime in there, which is kind of cool (e.g. https://openscm-runner--85.org.readthedocs.build/en/85/notebooks.html#notebook-execution-info).

Basically all worked. Had to do a bunch of fixes but not that surprising given how complicated the repo is. I'm going to leave mypy failing for now (too much legacy to fix that right now). I'll take the learnings back into the copier repo next week.

Copy link
Collaborator

@lewisjared lewisjared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work grinding through this

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
Co-authored-by: Jared Lewis <[email protected]>
@znicholls znicholls merged commit e039378 into master Jan 22, 2024
19 checks passed
@znicholls znicholls deleted the copier branch January 22, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants