-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to copier template #85
Conversation
I can try to clean up the ciceroscm pandas< 2 issue @znicholls, if that's helpful (probably about time anyway)... |
Would be great, I'll ping you once I've stopped moving things here so you
have something stable to work from
…On Fri, Jan 19, 2024, 10:41 Marit Sandstad ***@***.***> wrote:
I can try to clean up the ciceroscm pandas< 2 issue @znicholls
<https://github.com/znicholls>, if that's helpful (probably about time
anyway)...
—
Reply to this email directly, view it on GitHub
<#85 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFUH5G3JW62Q7SIPWDLEPO3YPI5THAVCNFSM6AAAAABBTM6W4SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBQGA3TAOBVG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
Great, I'll wait for a ping, then :-) |
@lewisjared not really sure if review can do anything meaningful but just as an FYI. Docs build based on notebooks and have runtime in there, which is kind of cool (e.g. https://openscm-runner--85.org.readthedocs.build/en/85/notebooks.html#notebook-execution-info). Basically all worked. Had to do a bunch of fixes but not that surprising given how complicated the repo is. I'm going to leave mypy failing for now (too much legacy to fix that right now). I'll take the learnings back into the copier repo next week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work grinding through this
Co-authored-by: Jared Lewis <[email protected]>
changelog