Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOFTWARE-5890: Automerge check for unknown institution ID #3956

Conversation

mwestphall
Copy link
Collaborator

  • Add a new check in automerge_check.py that compares the InstitutionID in edited projects files to the list provided by topology-institutions.osg-htc.org/api/institution_ids . Raise the existing ORGS_ADDED error if this occurs.
  • Update the error message for ORGS_ADDED to make note of valid institution ID requirement.

@mwestphall mwestphall requested a review from matyasselmeci June 7, 2024 20:41
Copy link
Collaborator

@matyasselmeci matyasselmeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine; you should make sure requests is installed into the webhook container but after that, feel free to merge.

@mwestphall mwestphall merged commit f46e18a into opensciencegrid:master Jun 12, 2024
2 checks passed
@mwestphall mwestphall deleted the feature/automerge-unknown-institution-id branch June 12, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants