Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "production" boolean to resources in namespaces JSON (SOFTWARE-5862) #3900

Conversation

matyasselmeci
Copy link
Collaborator

No description provided.

@matyasselmeci matyasselmeci marked this pull request as draft May 16, 2024 22:56
Copy link
Member

@brianhlin brianhlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- account for new argument to Resource() constructor
- test new "production" boolean
@matyasselmeci matyasselmeci force-pushed the pr/production-in-namespaces-json.SOFTWARE-5862 branch from 22c0802 to 793fdb0 Compare May 17, 2024 16:03
@matyasselmeci matyasselmeci marked this pull request as ready for review May 17, 2024 16:04
@matyasselmeci matyasselmeci merged commit 76200bf into opensciencegrid:master May 17, 2024
2 checks passed
@matyasselmeci matyasselmeci deleted the pr/production-in-namespaces-json.SOFTWARE-5862 branch May 17, 2024 16:17
@matyasselmeci matyasselmeci restored the pr/production-in-namespaces-json.SOFTWARE-5862 branch May 17, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants