Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Executive Contact #3786

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Add Executive Contact #3786

merged 1 commit into from
Apr 10, 2024

Conversation

brianhlin
Copy link
Member

This was faster than creating the ticket

osg-cat
osg-cat reviewed Apr 10, 2024
View reviewed changes
Copy link
Contributor

@osg-cat osg-cat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have forgotten already — does anything explicit need to be done to include the new executive type in “all”? I think not… I think the filtering was subtractive… but just asking.

@brianhlin
Copy link
Member Author

Nope, I grep'ed around for existing contact classes and these were the only two locations

@brianhlin brianhlin force-pushed the add-executive-contact branch from c0d9f7c to e889be1 Compare April 10, 2024 19:47
@brianhlin brianhlin merged commit 6fac522 into opensciencegrid:master Apr 10, 2024
2 checks passed
@brianhlin brianhlin deleted the add-executive-contact branch April 10, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osg-cat osg-cat osg-cat left review comments

@matyasselmeci matyasselmeci matyasselmeci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brianhlin @matyasselmeci @osg-cat