Fixed pattern matching error with NetworkInterface objects (SOFTWARE-5423) #3654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sqqueak could you rebase this on the latest |
sqqueak
force-pushed
the
fix-string-error
branch
from
bf5d325 to
8d552c4
Compare
|
D'oh, we've had a lot of activity on this repo today. Next time could you do the force push and ping me on Slack so I can hit merge? |
sqqueak
force-pushed
the
fix-string-error
branch
2 times, most recently
from
2211cb7 to
8d552c4
Compare
sqqueak
force-pushed
the
fix-string-error
branch
from
8d552c4 to
441dd35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An error occurs when running the osg-notify script with specific parameters (see more at this ticket). This is due to a utility function trying to perform pattern matching on a
NetworkInterfaceobject, which does not have a default string representation. I modified the pattern matching logic so that it would look for patterns in the correct location and data type.