Fixed bug where osg-notify gets stuck in a loop while prompting for user password (SOFTWARE-5824) #3646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianhlin
reviewed
Feb 14, 2024
|
Uh-oh @sqqueak this It looks like this has gone a bit wonky based on the diff + commits in this PR. Feel free to swing by and we can do some surgery to sort it all out |
sqqueak
force-pushed
the
fix-loop-bug
branch
2 times, most recently
from
9257c3b to
6fcf7a1
Compare
sqqueak
force-pushed
the
fix-loop-bug
branch
from
6fcf7a1 to
5707f6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing osg-notify, it repeatedly prompted me to enter a password despite the password being correct. The script only stopped asking for a password once three incorrect attempts were made. This behavior can be traced back to these two while loops. There is no exit or break condition when there are no exceptions, so I added a break statement which fixed the issue. See this Jira ticket.