Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 1596 Enable transpower publisher plugin #1598

Merged
merged 5 commits into from
Dec 3, 2024

Conversation

clepski
Copy link
Collaborator

@clepski clepski commented Nov 18, 2024

Changes

  • Add global styles accoring to the core API specs
  • Handle openenergytools edit events v2 (which are slighty different from open scd edit events v2)
  • Add material symbols

Demo

Add custom edtior plugin in https://openscd.github.io/open-scd/pr-preview/pr-1598/
with https://danyill.github.io/scl-editor/plugins/oscd-publisher/oscd-publisher.js

Up for discussion

  • Should both material icons and material symbols (3 mb file) be loaded? Can we stick with just one?
  • Do we want to add the publisher plugin to the default list of plugins?

closes #1596

Copy link
Contributor

github-actions bot commented Nov 18, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-12-03 08:55 UTC

@Sander3003
Copy link
Member

Sander3003 commented Nov 18, 2024

Should both material icons and material symbols (3 mb file) be loaded? Can we stick with just one?

Yes if it is a small fix, otherwise, keep both

Do we want to add the publisher plugin to the default list of plugins?

No, it is not a OpenSCD organisation plug-in

I'm happy with whatever the community decides (only my view, no hard requirement)

@clepski clepski marked this pull request as ready for review December 3, 2024 07:56
@trusz trusz merged commit 3697c38 into main Dec 3, 2024
6 checks passed
@trusz trusz deleted the feat/1596-enable-publisher-plugin branch December 3, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Publisher plugin from transpower in open scd
3 participants