Add scipts to monitor nginx ssl session ticket keys and session ticket r... #7
Conversation
|
change code style and file naming style. Make them consistent with existing ones. |
| @@ -0,0 +1,19 @@ | |||
| // module nginx.openssl_ex_data | |||
There was a problem hiding this comment.
Hmm, I still don't like this module name. given that all these functions are related to OpenSSL only (and not nginx at all), you should probably just name it openssl instead of nginx.openssl_ex_data. Thoughts?
|
@lziest Also, will you add some corresponding docs to the file |
lziest
force-pushed
the
lziest/ngx-ssl-session-ticket-keys
branch
from
941888d to
3eb5acd
Compare
|
Add docs, squashed minor changes and rebased. |
| @@ -0,0 +1,19 @@ | |||
| // module nginx.openssl | |||
There was a problem hiding this comment.
Let's rename it to just openssl because this module has nothing to do with nginx.
|
Please |
|
|
||
| ```bash | ||
| # assuming one nginx worker process has the pid 3781. | ||
| $ ./samples/ngx-ssl-session-ticket-keys.sxx -I ./tapset -x 3781 |
There was a problem hiding this comment.
Please also add a line to set PATH environment, just like the docs for other tools. Thank you :)
lziest
force-pushed
the
lziest/ngx-ssl-session-ticket-keys
branch
from
72bb100 to
bba6a34
Compare
| $ export PATH=$PWD:$PATH | ||
|
|
||
| # assuming one nginx worker process has the pid 3781. | ||
| $ ./samples/ngx-ssl-session-ticket-keys.sxx -x 3781 |
There was a problem hiding this comment.
Will you add some sample outputs?
There was a problem hiding this comment.
Also, please add sample outputs here in its docs and also some brief explanation if not too obvious.
|
@lziest Please add support for the |
| printf("last dec key:\n") | ||
| print_session_ticket_key(last_key) | ||
| } | ||
| } |
There was a problem hiding this comment.
I think this tool should exit here as soon as it dumps the first key set. Thoughts?
|
I would like to squash the commits into one once it's ok to merge |
| dec key: | ||
| key name: f14c1d6611ad4802eccf6332f3b356f5 | ||
| dec key: | ||
| key name: b9cb4fb269a4148cc7c19c71d9e8554d |
There was a problem hiding this comment.
Still no indentation in the output? It's hard to look ;)
| } | ||
| printf("Session ticket resumption attempts ratio: %d%%\n", ratio1) | ||
| printf("Session ticket resumption success ratio: %d%%\n", ratio2) | ||
| printf("Total session ticket resumption rate: %d%%\n", |
There was a problem hiding this comment.
I've found these ratio descriptions a bit confusing. Maybe you can make it even clearer? How about these:
Ticket resumption attempts ratio in all SSL sessions: %d
Ticket resumption success ratio in all attempts: %d
Resumed ticket sessions in all SSL sessions: %d
...esumptions.