-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add headers if not set #65
base: master
Are you sure you want to change the base?
Conversation
@@ -52,3 +52,6 @@ nginx | |||
*.plist | |||
a.patch | |||
Makefile | |||
autoconf.err | |||
autotest | |||
objs/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will you remove these? Seems like you are not using the standard building process based on util/build.sh
.
@detailyang Please use the ngx-releng tool to check the coding style and other issues in your changes. Also, please use the reindex tool to re-format your |
} | ||
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line trailing spaces?
@detailyang Thanks for the contribution! Please take care of the issues pointed out by my comments above. Thanks! |
@agentzh Thanks! |
Is there any external help needed to bring this PR to completion? |
what status? |
What's the current status on this PR? |
@agentzh What's the current status on this PR? |
Any progress there? I could really use this feature. |
+1 ... it will be very helpful for us. |
Hello.
This PR is about the issue #60 for @SamMousa . It would add header if not present the specified header.
new option (-i) usage as the following:
@agentzh please review this PR 😁