Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add headers if not set #65

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

Conversation

detailyang
Copy link

Hello.
This PR is about the issue #60 for @SamMousa . It would add header if not present the specified header.
new option (-i) usage as the following:

 # add input header X-Foo *only* if it `X-Foo` doesnt exist
 more_set_input_headers -i 'X-Foo: howdy';

 # add output header X-Foo *only* if it `X-Foo` doesnt exist
 more_set_headers -i 'X-Foo: howdy';

@agentzh please review this PR 😁

@@ -52,3 +52,6 @@ nginx
*.plist
a.patch
Makefile
autoconf.err
autotest
objs/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will you remove these? Seems like you are not using the standard building process based on util/build.sh.

@agentzh
Copy link
Member

agentzh commented Aug 17, 2016

@detailyang Please use the ngx-releng tool to check the coding style and other issues in your changes.

Also, please use the reindex tool to re-format your .t files.

}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line trailing spaces?

@agentzh
Copy link
Member

agentzh commented Aug 17, 2016

@detailyang Thanks for the contribution! Please take care of the issues pointed out by my comments above. Thanks!

@detailyang
Copy link
Author

@agentzh
This time i check the code style pointed out by you comments above carefully. Please review again 😁

Thanks!

@aleksandrs-ledovskis
Copy link

@agentzh / @detailyang

Is there any external help needed to bring this PR to completion?

@Fudoshiki
Copy link

what status?

@lmm-git
Copy link

lmm-git commented Apr 14, 2020

What's the current status on this PR?

@ghost
Copy link

ghost commented Jul 27, 2020

@agentzh What's the current status on this PR?

@jiricerhan
Copy link

Any progress there? I could really use this feature.

@janreges
Copy link

+1 ... it will be very helpful for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants