Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing IndexError when opening nexrad Split Cut Mode file #246

Merged
merged 9 commits into from
Nov 28, 2024

Conversation

aladinor
Copy link
Member

@aladinor aladinor commented Nov 19, 2024

fixing IndexError when opening nexrad Split Cut Mode file

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 93.57%. Comparing base (9796807) to head (26c2992).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
xradar/io/backends/nexrad_level2.py 57.14% 3 Missing ⚠️
xradar/io/backends/common.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #246      +/-   ##
==========================================
- Coverage   93.64%   93.57%   -0.07%     
==========================================
  Files          26       26              
  Lines        5032     5041       +9     
==========================================
+ Hits         4712     4717       +5     
- Misses        320      324       +4     
Flag Coverage Δ
notebooktests 78.93% <63.63%> (-0.05%) ⬇️
unittests 93.15% <63.63%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

xradar/io/backends/nexrad_level2.py Outdated Show resolved Hide resolved
xradar/io/backends/nexrad_level2.py Outdated Show resolved Hide resolved
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@kmuehlbauer kmuehlbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @aladinor!

@kmuehlbauer
Copy link
Collaborator

@aladinor Can you fix the conflicts and add an entry to history.md? I think this is good to merge.

@kmuehlbauer kmuehlbauer merged commit 836a4c5 into openradar:main Nov 28, 2024
10 of 12 checks passed
@kmuehlbauer
Copy link
Collaborator

Thanks @aladinor!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Corrupted NexRad File?
2 participants