Provide mechanism for disabling legacy tool names #2114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current PRRTE tool names can conflict with those from other
packages (e.g., "pterm" with Putty). While this can be resolved
through use of PATH, we can try to be a bit more friendly and
revise the tool names. However, we have to also be considerate
of those who already use PRRTE tools, so let's create a compromise.
Rename the tools of concern in a "standardized" manner so people
can easily discern the new variations:
"pterm" moves to "prte-term"
"prun" moves to "prte-submit"
"prte_info" moves to "prte-info"
We leave "prte", "prterun", and "prted" alone. This provides a
consistent naming scheme. We also add a new configure option
("--enable-legacy-tools") that causes the original tool names
to be symlinked to the corresponding new name. Thus, "pterm"
is retained in that situation.
For now, we default the new configure option to be "yes" so that
the old names are present. If someone wants to build without
the old names, then they will need to "--disable-legacy-tools".
Signed-off-by: Ralph Castain <[email protected]>
Signed-off-by: Ralph Castain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current PRRTE tool names can conflict with those from other packages (e.g., "pterm" with Putty). While this can be resolved through use of PATH, we can try to be a bit more friendly and revise the tool names. However, we have to also be considerate of those who already use PRRTE tools, so let's create a compromise.
Rename the tools of concern in a "standardized" manner so people can easily discern the new variations:
"pterm" moves to "prte-term"
"prun" moves to "prte-submit"
"prte_info" moves to "prte-info"
We leave "prte", "prterun", and "prted" alone. This provides a consistent naming scheme. We also add a new configure option ("--enable-legacy-tools") that causes the original tool names to be symlinked to the corresponding new name. Thus, "pterm" is retained in that situation.
For now, we default the new configure option to be "yes" so that the old names are present. If someone wants to build without the old names, then they will need to "--disable-legacy-tools".
Fixes #1836