Multiple commits #2032
Merged
Multiple commits #2032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Naughton <[email protected]> (cherry picked from commit 545a88b)
Signed-off-by: Thomas Naughton <[email protected]> (cherry picked from commit 151842a)
Signed-off-by: Thomas Naughton <[email protected]> (cherry picked from commit c820507)
Restore processing of interface include and exclude parameters - not sure where it went, but bring it back anyway. Signed-off-by: Ralph Castain <[email protected]> (cherry picked from commit 99e4e24)
Protect against the envar version of the Slurm custom args MCA param. This is an unfortunate hack that hopefully will eventually go away. See both of the following for detailed explanations and discussion: openpmix#1974 open-mpi/ompi#12471 Orgs/users wanting to add custom args to the internal "srun" command used to spawn the PRRTE daemons must do so via the default MCA param files (system or user), or via the prterun (or its proxy) cmd line Signed-off-by: Ralph Castain <[email protected]> (cherry picked from commit 28432ed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoid warnings (as errors) spots (init vars, etc.)
Signed-off-by: Thomas Naughton [email protected]
(cherry picked from commit 545a88b)
remove unused Level var
Signed-off-by: Thomas Naughton [email protected]
(cherry picked from commit 151842a)
init installdirs structure (avoids warn-as-error)
Signed-off-by: Thomas Naughton [email protected]
(cherry picked from commit c820507)
Pay attention to interface include/exclude params
Restore processing of interface include and exclude
parameters - not sure where it went, but bring it
back anyway.
Signed-off-by: Ralph Castain [email protected]
(cherry picked from commit 99e4e24)
Protect against the envar version of the Slurm custom args param
Protect against the envar version of the Slurm
custom args MCA param. This is an unfortunate
hack that hopefully will eventually go away.
See both of the following for detailed
explanations and discussion:
#1974
open-mpi/ompi#12471
Orgs/users wanting to add custom args to the
internal "srun" command used to spawn the
PRRTE daemons must do so via the default MCA
param files (system or user), or via the
prterun (or its proxy) cmd line
Signed-off-by: Ralph Castain [email protected]
(cherry picked from commit 28432ed)