RA-950: Add LastVisit and EditVisit require an EndDate #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mogoodrich
reviewed
Jan 23, 2020
| Date actualStopDate = stopDatetime; | ||
| if (stopDatetime == null){ | ||
| stopDatetime = new Date(); | ||
| } |
There was a problem hiding this comment.
Is this just to avoid a null pointer exception on line 792? If so, I would just add a null check there, that is:
if (if stopDatetime != null && stopDatetime.after(new Date())) {
There was a problem hiding this comment.
Thanx @mogoodrich I have adjusted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.openmrs.org/browse/RA-950
I did the following
1.Enabled adding a past visit with a start date but no end date
2.But disabled adding a past visit with a start date but no end date if this would overlap with another existing visit
3.Enabled editing a closed visit and remove its end date
4.But disabled editing a closed visit and remove its end date if this would overlap with another existing visit
Other changes are in core-apps openmrs/openmrs-module-coreapps#275