Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) Display correct count of search results in the compact patient search #864

Merged
merged 1 commit into from
Oct 28, 2023
Merged

(fix) Display correct count of search results in the compact patient search #864

merged 1 commit into from
Oct 28, 2023

Conversation

vasharma05
Copy link
Member

@vasharma05 vasharma05 commented Oct 27, 2023 •
edited by denniskigen
Loading

Requirements

Summary

This PR fixes the count of search results shown in the compact patient search. Previously, the count shown at the top of the search UI used searchResults.length to compute the total count. This was incorrect as only 10 results would be shown at any time until the user scrolled to trigger fetching the next 10 patients. Deriving the count from totalResults shows the correct number of matching patients from a search without the need for scrolling through the entire list.

Screenshots

Before

CleanShot 2023-10-28 at 9  54 23@2x

After

CleanShot 2023-10-28 at 9  54 05@2x

Related Issue

None

Other

None

@vasharma05 vasharma05 changed the title (fix) Display correct count of search results (fix) Display correct count of search results in the compact patient search Oct 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023 •
edited
Loading

Size Change: -2 B (0%)

Total Size: 2.36 MB

ℹ️ View Unchanged
Filename Size Change
packages/esm-active-visits-app/dist/130.js 172 kB 0 B
packages/esm-active-visits-app/dist/255.js 2.21 kB 0 B
packages/esm-active-visits-app/dist/316.js 42.9 kB 0 B
packages/esm-active-visits-app/dist/319.js 631 B 0 B
packages/esm-active-visits-app/dist/382.js 1.15 kB 0 B
packages/esm-active-visits-app/dist/403.js 7.16 kB 0 B
packages/esm-active-visits-app/dist/459.js 50.1 kB 0 B
packages/esm-active-visits-app/dist/460.js 727 B 0 B
packages/esm-active-visits-app/dist/574.js 553 B 0 B
packages/esm-active-visits-app/dist/588.js 6.66 kB 0 B
packages/esm-active-visits-app/dist/629.js 7.63 kB 0 B
packages/esm-active-visits-app/dist/635.js 1.15 kB 0 B
packages/esm-active-visits-app/dist/729.js 3.1 kB 0 B
packages/esm-active-visits-app/dist/757.js 649 B 0 B
packages/esm-active-visits-app/dist/784.js 2.63 kB 0 B
packages/esm-active-visits-app/dist/788.js 551 B 0 B
packages/esm-active-visits-app/dist/807.js 864 B 0 B
packages/esm-active-visits-app/dist/833.js 669 B 0 B
packages/esm-active-visits-app/dist/842.js 900 B 0 B
packages/esm-active-visits-app/dist/879.js 2.94 kB 0 B
packages/esm-active-visits-app/dist/main.js 3.52 kB 0 B
packages/esm-active-visits-app/dist/openmrs-esm-active-visits-app.js 3.33 kB 0 B
packages/esm-appointments-app/dist/130.js 172 kB 0 B
packages/esm-appointments-app/dist/152.js 261 B 0 B
packages/esm-appointments-app/dist/223.js 20.9 kB 0 B
packages/esm-appointments-app/dist/255.js 2.23 kB 0 B
packages/esm-appointments-app/dist/297.js 2.49 kB 0 B
packages/esm-appointments-app/dist/303.js 260 B 0 B
packages/esm-appointments-app/dist/315.js 140 kB 0 B
packages/esm-appointments-app/dist/319.js 1.95 kB 0 B
packages/esm-appointments-app/dist/328.js 11.6 kB 0 B
packages/esm-appointments-app/dist/381.js 10.3 kB 0 B
packages/esm-appointments-app/dist/403.js 1.96 kB 0 B
packages/esm-appointments-app/dist/460.js 2.16 kB 0 B
packages/esm-appointments-app/dist/574.js 1.72 kB 0 B
packages/esm-appointments-app/dist/591.js 16.9 kB 0 B
packages/esm-appointments-app/dist/610.js 6.71 kB 0 B
packages/esm-appointments-app/dist/729.js 3.1 kB 0 B
packages/esm-appointments-app/dist/735.js 11.3 kB 0 B
packages/esm-appointments-app/dist/757.js 1.73 kB 0 B
packages/esm-appointments-app/dist/784.js 2.63 kB 0 B
packages/esm-appointments-app/dist/788.js 1.73 kB 0 B
packages/esm-appointments-app/dist/80.js 5.1 kB 0 B
packages/esm-appointments-app/dist/807.js 2.39 kB 0 B
packages/esm-appointments-app/dist/833.js 2.03 kB 0 B
packages/esm-appointments-app/dist/928.js 660 B 0 B
packages/esm-appointments-app/dist/975.js 103 kB 0 B
packages/esm-appointments-app/dist/main.js 5.64 kB 0 B
packages/esm-appointments-app/dist/openmrs-esm-appointments-app.js 3.28 kB 0 B
packages/esm-patient-list-app/dist/130.js 172 kB 0 B
packages/esm-patient-list-app/dist/255.js 2.21 kB 0 B
packages/esm-patient-list-app/dist/294.js 5.74 kB 0 B
packages/esm-patient-list-app/dist/319.js 1.32 kB 0 B
packages/esm-patient-list-app/dist/37.js 1.52 kB 0 B
packages/esm-patient-list-app/dist/382.js 1.15 kB 0 B
packages/esm-patient-list-app/dist/460.js 1.49 kB 0 B
packages/esm-patient-list-app/dist/537.js 534 B 0 B
packages/esm-patient-list-app/dist/565.js 2.65 kB 0 B
packages/esm-patient-list-app/dist/574.js 1.14 kB 0 B
packages/esm-patient-list-app/dist/588.js 6.66 kB 0 B
packages/esm-patient-list-app/dist/591.js 16.9 kB 0 B
packages/esm-patient-list-app/dist/635.js 1.15 kB 0 B
packages/esm-patient-list-app/dist/646.js 2.29 kB 0 B
packages/esm-patient-list-app/dist/716.js 4.62 kB 0 B
packages/esm-patient-list-app/dist/729.js 3.1 kB 0 B
packages/esm-patient-list-app/dist/757.js 1.3 kB 0 B
packages/esm-patient-list-app/dist/784.js 2.63 kB 0 B
packages/esm-patient-list-app/dist/788.js 1.14 kB 0 B
packages/esm-patient-list-app/dist/791.js 1.53 kB 0 B
packages/esm-patient-list-app/dist/795.js 14.6 kB 0 B
packages/esm-patient-list-app/dist/807.js 1.64 kB 0 B
packages/esm-patient-list-app/dist/833.js 1.35 kB 0 B
packages/esm-patient-list-app/dist/970.js 5.96 kB 0 B
packages/esm-patient-list-app/dist/975.js 98.1 kB 0 B
packages/esm-patient-list-app/dist/main.js 3.96 kB 0 B
packages/esm-patient-list-app/dist/openmrs-esm-patient-list-app.js 3.29 kB 0 B
packages/esm-patient-registration-app/dist/130.js 172 kB 0 B
packages/esm-patient-registration-app/dist/152.js 265 B 0 B
packages/esm-patient-registration-app/dist/167.js 27.2 kB 0 B
packages/esm-patient-registration-app/dist/240.js 26.2 kB 0 B
packages/esm-patient-registration-app/dist/255.js 2.21 kB 0 B
packages/esm-patient-registration-app/dist/294.js 23.4 kB 0 B
packages/esm-patient-registration-app/dist/303.js 263 B 0 B
packages/esm-patient-registration-app/dist/319.js 1.63 kB 0 B
packages/esm-patient-registration-app/dist/37.js 2.08 kB 0 B
packages/esm-patient-registration-app/dist/460.js 1.69 kB 0 B
packages/esm-patient-registration-app/dist/491.js 28.9 kB 0 B
packages/esm-patient-registration-app/dist/537.js 3.74 kB 0 B
packages/esm-patient-registration-app/dist/574.js 1.39 kB 0 B
packages/esm-patient-registration-app/dist/591.js 16.9 kB 0 B
packages/esm-patient-registration-app/dist/62.js 6.86 kB 0 B
packages/esm-patient-registration-app/dist/631.js 7.96 kB 0 B
packages/esm-patient-registration-app/dist/635.js 456 B 0 B
packages/esm-patient-registration-app/dist/68.js 9.61 kB 0 B
packages/esm-patient-registration-app/dist/729.js 3.1 kB 0 B
packages/esm-patient-registration-app/dist/735.js 464 B 0 B
packages/esm-patient-registration-app/dist/742.js 720 B 0 B
packages/esm-patient-registration-app/dist/757.js 1.65 kB 0 B
packages/esm-patient-registration-app/dist/784.js 2.64 kB 0 B
packages/esm-patient-registration-app/dist/788.js 1.32 kB 0 B
packages/esm-patient-registration-app/dist/807.js 2.09 kB 0 B
packages/esm-patient-registration-app/dist/833.js 1.62 kB 0 B
packages/esm-patient-registration-app/dist/879.js 2.94 kB 0 B
packages/esm-patient-registration-app/dist/975.js 425 B 0 B
packages/esm-patient-registration-app/dist/main.js 19.7 kB 0 B
packages/esm-patient-registration-app/dist/openmrs-esm-patient-registration-app.js 3.35 kB 0 B
packages/esm-patient-search-app/dist/110.js 17 kB 0 B
packages/esm-patient-search-app/dist/128.js 2.01 kB 0 B
packages/esm-patient-search-app/dist/130.js 172 kB 0 B
packages/esm-patient-search-app/dist/152.js 264 B 0 B
packages/esm-patient-search-app/dist/174.js 1.6 kB 0 B
packages/esm-patient-search-app/dist/255.js 2.21 kB 0 B
packages/esm-patient-search-app/dist/303.js 263 B 0 B
packages/esm-patient-search-app/dist/319.js 936 B 0 B
packages/esm-patient-search-app/dist/327.js 1.06 kB 0 B
packages/esm-patient-search-app/dist/357.js 5.69 kB -2 B (0%)
packages/esm-patient-search-app/dist/382.js 1.15 kB 0 B
packages/esm-patient-search-app/dist/460.js 1.06 kB 0 B
packages/esm-patient-search-app/dist/474.js 24.9 kB 0 B
packages/esm-patient-search-app/dist/519.js 5.08 kB 0 B
packages/esm-patient-search-app/dist/574.js 781 B 0 B
packages/esm-patient-search-app/dist/588.js 6.66 kB 0 B
packages/esm-patient-search-app/dist/591.js 16.9 kB 0 B
packages/esm-patient-search-app/dist/635.js 1.15 kB 0 B
packages/esm-patient-search-app/dist/729.js 3.1 kB 0 B
packages/esm-patient-search-app/dist/757.js 938 B 0 B
packages/esm-patient-search-app/dist/784.js 2.63 kB 0 B
packages/esm-patient-search-app/dist/788.js 776 B 0 B
packages/esm-patient-search-app/dist/807.js 1.11 kB 0 B
packages/esm-patient-search-app/dist/833.js 951 B 0 B
packages/esm-patient-search-app/dist/842.js 2.08 kB 0 B
packages/esm-patient-search-app/dist/939.js 4.4 kB 0 B
packages/esm-patient-search-app/dist/main.js 3.62 kB 0 B
packages/esm-patient-search-app/dist/openmrs-esm-patient-search-app.js 3.34 kB 0 B
packages/esm-service-queues-app/dist/130.js 172 kB 0 B
packages/esm-service-queues-app/dist/152.js 264 B 0 B
packages/esm-service-queues-app/dist/176.js 5.76 kB 0 B
packages/esm-service-queues-app/dist/242.js 219 B 0 B
packages/esm-service-queues-app/dist/255.js 2.23 kB 0 B
packages/esm-service-queues-app/dist/286.js 2.87 kB 0 B
packages/esm-service-queues-app/dist/303.js 264 B 0 B
packages/esm-service-queues-app/dist/308.js 8.15 kB 0 B
packages/esm-service-queues-app/dist/311.js 4.19 kB 0 B
packages/esm-service-queues-app/dist/315.js 1.16 kB 0 B
packages/esm-service-queues-app/dist/319.js 3.15 kB 0 B
packages/esm-service-queues-app/dist/328.js 3.08 kB 0 B
packages/esm-service-queues-app/dist/330.js 8.6 kB 0 B
packages/esm-service-queues-app/dist/366.js 2.14 kB 0 B
packages/esm-service-queues-app/dist/398.js 2.03 kB 0 B
packages/esm-service-queues-app/dist/425.js 3.42 kB 0 B
packages/esm-service-queues-app/dist/433.js 25.7 kB 0 B
packages/esm-service-queues-app/dist/457.js 2.5 kB 0 B
packages/esm-service-queues-app/dist/460.js 3.98 kB 0 B
packages/esm-service-queues-app/dist/53.js 3.11 kB 0 B
packages/esm-service-queues-app/dist/574.js 3.15 kB 0 B
packages/esm-service-queues-app/dist/582.js 151 kB 0 B
packages/esm-service-queues-app/dist/591.js 16.9 kB 0 B
packages/esm-service-queues-app/dist/610.js 6.71 kB 0 B
packages/esm-service-queues-app/dist/616.js 3.61 kB 0 B
packages/esm-service-queues-app/dist/617.js 4.07 kB 0 B
packages/esm-service-queues-app/dist/627.js 2.94 kB 0 B
packages/esm-service-queues-app/dist/680.js 2.54 kB 0 B
packages/esm-service-queues-app/dist/719.js 5.38 kB 0 B
packages/esm-service-queues-app/dist/729.js 3.1 kB 0 B
packages/esm-service-queues-app/dist/757.js 3.15 kB 0 B
packages/esm-service-queues-app/dist/764.js 5.19 kB 0 B
packages/esm-service-queues-app/dist/766.js 4.74 kB 0 B
packages/esm-service-queues-app/dist/784.js 2.63 kB 0 B
packages/esm-service-queues-app/dist/788.js 3.13 kB 0 B
packages/esm-service-queues-app/dist/807.js 4.38 kB 0 B
packages/esm-service-queues-app/dist/833.js 3.75 kB 0 B
packages/esm-service-queues-app/dist/86.js 4.4 kB 0 B
packages/esm-service-queues-app/dist/944.js 2.77 kB 0 B
packages/esm-service-queues-app/dist/981.js 3.63 kB 0 B
packages/esm-service-queues-app/dist/main.js 4.15 kB 0 B
packages/esm-service-queues-app/dist/openmrs-esm-service-queues-app.js 3.3 kB 0 B

compressed-size-action

@denniskigen denniskigen force-pushed the fix/search-results-count branch from 5ae859c to 39084be Compare October 28, 2023 06:49
denniskigen
denniskigen approved these changes Oct 28, 2023
View reviewed changes
Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @vasharma05! Is this also the case in the advanced search page?

@denniskigen denniskigen merged commit b0604ed into main Oct 28, 2023
6 checks passed
@denniskigen denniskigen deleted the fix/search-results-count branch October 28, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denniskigen denniskigen denniskigen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vasharma05 @denniskigen