(feat) Add config property for rendering the Create appointment button
#838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mseaton
reviewed
Oct 9, 2023
There was a problem hiding this comment.
I'm adding @mogoodrich and @denniskigen as reviewers here. I know Mark is also working on a PR for appointment changes. Is this change being done in the context of a ticket? Please reference the ticket if so, and please create a ticket and reference it if not. Thanks.
mogoodrich
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
Yes @CynthiaKamau this seems good to me, but as @mseaton says, let's create tickets for all our changes going forward, so we can document in them the reason for a change. Thanks!
denniskigen
reviewed
Oct 26, 2023
| @@ -71,6 +71,11 @@ export const configSchema = { | |||
| _description: 'The name of the patient identifier type to be used for the patient identifier field', | |||
| _default: 'OpenMRS ID', | |||
| }, | |||
| showCreateAppointmentButtons: { | |||
There was a problem hiding this comment.
Suggested change
| showCreateAppointmentButtons: { | |
| showCreateAppointmentButton: { |
denniskigen
reviewed
Oct 26, 2023
| @@ -71,6 +71,11 @@ export const configSchema = { | |||
| _description: 'The name of the patient identifier type to be used for the patient identifier field', | |||
| _default: 'OpenMRS ID', | |||
| }, | |||
| showCreateAppointmentButtons: { | |||
| _type: Type.Boolean, | |||
| _description: 'Whether to show the create appointment button`', | |||
There was a problem hiding this comment.
Suggested change
| _description: 'Whether to show the create appointment button`', | |
| _description: 'Whether or not `Create Appointment` button in the appointments page header gets rendered', |
denniskigen
reviewed
Oct 26, 2023
| }, | ||
| }} | ||
| /> | ||
| {showCreateAppointmentButtons && ( |
There was a problem hiding this comment.
Suggested change
| {showCreateAppointmentButtons && ( | |
| {showCreateAppointmentButton && ( |
denniskigen
reviewed
Oct 26, 2023
| import styles from './metrics-header.scss'; | ||
| import { spaBasePath } from '../constants'; | ||
| import AppointmentForm from '../appointments/forms/create-edit-form/appointments-form.component'; | ||
| import { closeOverlay, launchOverlay } from '../hooks/useOverlay'; | ||
|
|
||
| const MetricsHeader: React.FC = () => { | ||
| const { t } = useTranslation(); | ||
| const { showCreateAppointmentButtons } = useConfig(); |
There was a problem hiding this comment.
Suggested change
| const { showCreateAppointmentButtons } = useConfig(); | |
| const { showCreateAppointmentButton } = useConfig(); |
denniskigen
reviewed
Oct 26, 2023
| @@ -29,7 +30,7 @@ export const EmptyState: React.FC<EmptyStateProps> = ({ headerTitle, displayText | |||
| There are no {displayText} to display | |||
| </Trans> | |||
| </p> | |||
| {scheduleType === 'Scheduled' ? ( | |||
| {scheduleType === 'Scheduled' && showCreateAppointmentButtons ? ( | |||
There was a problem hiding this comment.
Suggested change
| {scheduleType === 'Scheduled' && showCreateAppointmentButtons ? ( | |
| {scheduleType === 'Scheduled' && showCreateAppointmentButton ? ( |
denniskigen
changed the title
Create appointment button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Add config to show/hide create appointment button
Screenshots
https://www.loom.com/share/929bc5bbebb2442a86c1783639c1d1f5?sid=b9e9b80b-0044-46f5-9741-de5f10237640
None.
Related Issue
None.
Other
None.