-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) O3-4221: Use react hook form and zod in the queue service form #1416
(feat) O3-4221: Use react hook form and zod in the queue service form #1416
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start, @Muppasanipraneeth. Left a few comments that should be straightforward to address.
packages/esm-service-queues-app/src/queue-services/queue-service-form.test.tsx
Outdated
Show resolved
Hide resolved
packages/esm-service-queues-app/src/queue-services/queue-service-form.test.tsx
Outdated
Show resolved
Hide resolved
packages/esm-service-queues-app/src/queue-services/queue-service-form.test.tsx
Outdated
Show resolved
Hide resolved
packages/esm-service-queues-app/src/queue-services/queue-service-form.workspace.tsx
Outdated
Show resolved
Hide resolved
packages/esm-service-queues-app/src/queue-services/queue-service-form.workspace.tsx
Outdated
Show resolved
Hide resolved
packages/esm-service-queues-app/src/queue-services/queue-service-form.workspace.tsx
Outdated
Show resolved
Hide resolved
packages/esm-service-queues-app/src/queue-services/queue-service-form.workspace.tsx
Outdated
Show resolved
Hide resolved
@denniskigen as you said made changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this off the ground, @Muppasanipraneeth. I've left some comments.
packages/esm-service-queues-app/src/queue-services/queue-service-form.workspace.tsx
Outdated
Show resolved
Hide resolved
packages/esm-service-queues-app/src/queue-services/queue-service-form.workspace.tsx
Outdated
Show resolved
Hide resolved
packages/esm-service-queues-app/src/queue-services/queue-service-form.workspace.tsx
Outdated
Show resolved
Hide resolved
packages/esm-service-queues-app/src/queue-services/queue-service-form.workspace.tsx
Outdated
Show resolved
Hide resolved
packages/esm-service-queues-app/src/queue-services/queue-service-form.workspace.tsx
Outdated
Show resolved
Hide resolved
packages/esm-service-queues-app/src/queue-services/queue-service-form.workspace.tsx
Outdated
Show resolved
Hide resolved
packages/esm-service-queues-app/src/queue-services/queue-service-form.workspace.tsx
Outdated
Show resolved
Hide resolved
packages/esm-service-queues-app/src/queue-services/queue-service-form.workspace.tsx
Outdated
Show resolved
Hide resolved
packages/esm-service-queues-app/src/queue-services/queue-service-form.workspace.tsx
Outdated
Show resolved
Hide resolved
packages/esm-service-queues-app/src/queue-services/queue-service-form.workspace.tsx
Outdated
Show resolved
Hide resolved
This is before using Carbon's built-in error handling means while using InlineNotificationScreen.Recording.2024-12-22.at.10.08.20.PM.movThis is after using Carbon's built-in error handlingScreen.Recording.2024-12-22.at.10.04.52.PM.mov |
packages/esm-service-queues-app/src/queue-services/queue-service-form.workspace.tsx
Outdated
Show resolved
Hide resolved
packages/esm-service-queues-app/src/queue-services/queue-service-form.workspace.tsx
Outdated
Show resolved
Hide resolved
packages/esm-service-queues-app/src/queue-services/queue-service-form.workspace.tsx
Outdated
Show resolved
Hide resolved
packages/esm-service-queues-app/src/queue-services/queue-service-form.workspace.tsx
Outdated
Show resolved
Hide resolved
packages/esm-service-queues-app/src/queue-services/queue-service-form.workspace.tsx
Outdated
Show resolved
Hide resolved
packages/esm-service-queues-app/src/queue-services/queue-service-form.workspace.tsx
Outdated
Show resolved
Hide resolved
8049b23
to
f2724f9
Compare
f2724f9
to
163daef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Thanks @denniskigen |
Thank you very much @Muppasanipraneeth for this work - I especially appreciated your detailed PR description and the before vs after videos :D Keep up the good work! |
@gracepotma thanks for appreciating and for your time😊 |
Requirements
Summary
This PR refactors the existing form validation logic to use Zod, a TypeScript-first schema validation library. The refactor provides the following benefits:
Key Changes
Screenshots
See below in PR thread
Related Issue
Other Notes