(fix) O3-4275: Alignment issue for Time and Duration fields on invalid input #1415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@denniskigen I have successfully pulled the latest changes from the upstream main branch and merged them into my feature branch. I ran all the tests locally, and everything is working fine with no errors. Please review the changes and feel free to merge the PR if everything looks good. Thanks! |
harshthakkr
force-pushed
the
fix/align-time-duration-fields
branch
from
ab53a45 to
a9bde8c
Compare
brandones
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
LGTM, thanks @harshthakkr for ID'ing the bug, ticketing, and fixing!
|
Thanks @brandones for reviewing and merging my PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This Pull Request fixes a UI bug in the Appointments Form of the esm-appointments-app module within the esm-patient-management-app monorepo. The issue was causing misalignment between the Time and Duration (minutes) fields when invalid input was entered in the Duration (minutes) field.
Screenshots
Before:
After:
Related Issue
O3-4275