(refactor) O3-3806: Refactor Service queue entries api call using OpenMrs Fetch All #1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandones
requested changes
Dec 19, 2024
packages/esm-service-queues-app/src/patient-queue-metrics/clinic-metrics.component.tsx
Show resolved
Hide resolved
brandones
requested changes
Jan 3, 2025
| const queueUpdateListener = useCallback(() => { | ||
| refetchAllData(); | ||
| }, [refetchAllData]); | ||
| const queueUpdateListener = useCallback(() => { |
There was a problem hiding this comment.
I think we simplify this further. I think we can get rid of all the queueUpdateListener and queue-entry-updated stuff, and whatever function it is that triggers the queue-entry-updated event. We can simply expose the mutate function and use that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
To use hooks already present in esm-core to fetch all the queue entries.
388370799-867ef32b-fb36-4a01-a49b-c5fbf7d3b0ff.webm
Related Issue
https://openmrs.atlassian.net/browse/O3-3806
Other