O3-4250 (feat) Ability to add Cash Points and Payment modes via a UI #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ODORA0
changed the title
ibacher
reviewed
Dec 12, 2024
| } from '@carbon/react'; | ||
| import { Add } from '@carbon/react/icons'; | ||
| import { useTranslation } from 'react-i18next'; | ||
| import axios from 'axios'; |
There was a problem hiding this comment.
Please, if at all possible, use openmrsFetch instead of axios.
CynthiaKamau
approved these changes
Dec 16, 2024
jabahum
approved these changes
Dec 18, 2024
jabahum
reviewed
Dec 18, 2024
| name: data.name, | ||
| uuid: data.uuid, | ||
| location: { uuid: data.location }, | ||
| const response = await openmrsFetch('/ws/rest/v1/billing/cashPoint', { |
There was a problem hiding this comment.
you could use restBaseUrl otherthan completing the entire url
| @@ -55,7 +53,7 @@ const PaymentModesConfig: React.FC = () => { | |||
|
|
|||
| const fetchPaymentModes = useCallback(async () => { | |||
| try { | |||
| const response = await axios.get(`${baseUrl}/billing/paymentMode?v=full`); | |||
| const response = await openmrsFetch('/ws/rest/v1/billing/paymentMode?v=full'); | |||
| await axios.post(`${baseUrl}/billing/paymentMode`, { | ||
| name: data.name, | ||
| description: data.description, | ||
| const response = await openmrsFetch('/ws/rest/v1/billing/paymentMode', { |
| @@ -117,7 +132,9 @@ const PaymentModesConfig: React.FC = () => { | |||
| if (!selectedPaymentMode) return; | |||
|
|
|||
| try { | |||
| await axios.delete(`${baseUrl}/billing/paymentMode/${selectedPaymentMode.uuid}`); | |||
| await openmrsFetch(`/ws/rest/v1/billing/paymentMode/${selectedPaymentMode.uuid}`, { | |||
jabahum
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
For changes to apps
If applicable
Summary
Add UI functionality for creating billing settings during facility configuration
setting e.g. cash points and payment modes via tables
Screenshots
Screen.Recording.2024-12-11.at.12.42.26.mov
Related Issue
https://openmrs.atlassian.net/browse/O3-4250
Other
To do
and existing bill (support to be added to the backend first)