Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent model refresh threading #126

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

johvincau
Copy link
Contributor

When calling openmc-plotter with the -s flag and specifying threads, this number would only be remembered for the first time loading the model. Any subsequent reloads called from the GUI would function as if openmc-plotter were run with no thread specification, returning to the default value for that machine.

This pull request adds a quick fix to enable any future loads/reloads of the model to use the number of threads as specified by the initial call of openmc-plotter.

Copy link
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! Also looks like the reload would have missed out on the model_path argument and I see you've included that too 👍

@paulromano paulromano merged commit 47d0a73 into openmc-dev:develop Oct 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants