Replace missing block for outside of sphere surface #15
Conversation
There was a problem hiding this comment.
Thanks for the quick fix on this @pshriwise but I think there are a couple things that need tweaking.
test/gold/nested_spheres.jou
Outdated
There was a problem hiding this comment.
I don't see any subtract commands here since I don't think the test case was defined properly
| middle_cell = openmc.Cell(region=-middle_sphere) | ||
| outer_cell = openmc.Cell(region=-outer_sphere) | ||
|
|
||
| g = openmc.Geometry([outer_cell, middle_cell, inner_cell]) |
There was a problem hiding this comment.
Is the order that the cells are listed in going to have an impact? I was expecting to see the outputs in the cubit journal file ordered by cell ID, but it looks reversed.
There was a problem hiding this comment.
could also be worth tacking on a vacuum boundary condition to the outer sphere so that it makes a viable geometry that could ostensibly be run in openmc
There was a problem hiding this comment.
Is the order that the cells are listed in going to have an impact? I was expecting to see the outputs in the cubit journal file ordered by cell ID, but it looks reversed.
I believe they'll be generated in the order they appear in the iterable passed to the Geometry object. Corresponding IDs on the volume objects in the resulting CAD would be great, but might be difficult to manage based on how Cubit handles ID spaces. An easier short-term solution would be to place each cell in it's own group with the ID in the name for reference to the original model.
could also be worth tacking on a vacuum boundary condition to the outer sphere so that it makes a viable geometry that could ostensibly be run in openmc
Agreed that it would be nice and I'm happy to include those changes here. Right now I'm planning on spending my time covering and verifying more geometry capabilities in the test suite (hopefully correctly in the future) than every test case being runnable in OpenMC.
Co-authored-by: Ethan Peterson <[email protected]>
Co-authored-by: Ethan Peterson <[email protected]>
This (re)adds support for the outer halfspace of sphere surfaces along with a new test to ensure it's working correctly.