Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding '#define _USE_MATH_DEFINES' to make M_PI declared in Intel and MSVC compilers #3238

Merged
merged 4 commits into from
Jan 7, 2025

Conversation

MAS-OUD
Copy link
Contributor

@MAS-OUD MAS-OUD commented Dec 25, 2024

the M_PI used in mesh.cpp, plot.cpp, and quartic_solver.cpp is undeclared in Intel and MSVC compilers. To make it declared in these compilers #define _USE_MATH_DEFINES must be added before #include <cmath>.

M_PI is undeclared in Intel and MSVC compilers. To make it declared in these compilers '#define _USE_MATH_DEFINES' must be added before '#include <cmath>'.
M_PI is undeclared in Intel and MSVC compilers. To make it declared in these compilers '#define _USE_MATH_DEFINES' must be added before '#include <cmath>'.
M_PI is undeclared in Intel and MSVC compilers. To make it declared in these compilers '#define _USE_MATH_DEFINES' must be added before '#include <cmath>'.
@MAS-OUD MAS-OUD requested a review from pshriwise as a code owner December 25, 2024 08:36
@MAS-OUD MAS-OUD changed the title Adding '#define _USE_MATH_DEFINES' to some files to make M_PI declared in Intel and MSVC compilers Adding '#define _USE_MATH_DEFINES' to make M_PI declared in Intel and MSVC compilers Dec 25, 2024
Copy link
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MAS-OUD!

@paulromano paulromano enabled auto-merge (squash) January 6, 2025 12:46
@MAS-OUD
Copy link
Contributor Author

MAS-OUD commented Jan 6, 2025

Thanks @MAS-OUD!

You're welcome @paulromano.

@paulromano paulromano merged commit 3933348 into openmc-dev:develop Jan 7, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants