Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carry next URL through authentication #4347

Draft
wants to merge 49 commits into
base: master
Choose a base branch
from
Draft

Carry next URL through authentication #4347

wants to merge 49 commits into from

Conversation

joemull
Copy link
Member

@joemull joemull commented Aug 7, 2024 •
edited
Loading

Closes #3899.

mauromsl
mauromsl reviewed Aug 7, 2024
View reviewed changes
src/core/logic.py Outdated
Comment on lines 41 to 46
reverse_with_next(
'core_reset_password',
kwargs={'token': reset_token.token},
request=request,
)
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, since request.site_type.site_url now takes in an optional query parameter, we want to avoid encoding the querystring onto the path parameter ahead of time. Instead, we can pass in the query elements to be encoded separately and delegete URL encoding to site_url. We could either use a regular dictionary or a mutable Querydict

@joemull joemull changed the title Carry next URL thorugh authentication Carry next URL through authentication Aug 7, 2024
ajrbyers and others added 28 commits September 13, 2024 12:09
@ajrbyers @mauromsl
Fixes the copyright notice label.
f6969a2
@joemull @ajrbyers
Add Dutch translation for copyright help text #4409
d75ddef
@ajrbyers
Reverts account and frozen author fields to charfields.
81020ae
@ajrbyers
Adds a button_classes var to style ORCID reg btn
4123003
@mauromsl @ajrbyers
#4405: Adds plain text sanitizer for model/forms
5a26ba1
@mauromsl @ajrbyers
#4405: Flag models to use new HTML sanitizer
8dc372d
@mauromsl @ajrbyers
#4405: Update validators on migrations
8fc72f4
@mauromsl @ajrbyers
#4405: Adds unit tests
99b66a3
@mauromsl @ajrbyers
4405: Adds acceptance tests
dc7a7a7
@ajrbyers
Sets default class for orcid reg button.
4d5dec8
@mauromsl @ajrbyers
#3337: Undo orcid login template breaking change
dae095c
@ajrbyers @mauromsl
#4412 Combine recommendation display checks into one.
cce7179
@ajrbyers @mauromsl
#4412 include reviews_small in previous change.
ac63374
@joemull @mauromsl
Update default typesetting guide openlibhums/typesetting#31
a2527d7
@ajrbyers @joemull
Fixes a bug where submit_info would clear CI.
aed1e6b
@ajrbyers @joemull
Reverts previous change. Adds new subclass that adds competing_intere…
2123e63 
…sts for the edit_metadata view.
@ajrbyers @joemull
Remove import.
83a1314
@ajrbyers @joemull
Initial WIP. Adds setting and filter.
fcd6ce7
@ajrbyers @joemull
Moves to securitytags, adds checks.
279c6aa
@ajrbyers @joemull
#4417 adds a tag for PII can_see_pii_tag
ec1ed8e 
Logic is moved to a helper function.
@ajrbyers @joemull
#4417 applies filter/tags to metadata screen.
88b0e36
@ajrbyers @joemull
#4417 adds checks to edit/metadata.html
f3f4acd
@ajrbyers @joemull
#4417 anonymises the edit metadata template
8517f05
@ajrbyers @joemull
#4417 anonymises the article log
5c5aecc
@mauromsl @joemull
Moves logic to logic.py module
ec9d353
@mauromsl @joemull
Adds new security decorator for SE PII check
9ac9dff
@mauromsl @joemull
Use new decorator on document manager
d665aa9
@mauromsl @joemull
Adds security decorator test case
abb2f28
mauromsl and others added 18 commits September 26, 2024 12:42
@mauromsl @joemull
Adds utility for cleanly overriding janeway setting in test
e5b2a1c
@mauromsl @joemull
Fix wrong logic on new SE PII checks
b98714c
@mauromsl @joemull
Fix test
d035bd4
@ajrbyers @joemull
#4417 include STAGE_ASSIGNED in list of stages
134004c
@ajrbyers @joemull
#4417 include securitytags as a builtin tag set
e12635c
@ajrbyers @joemull
#4417 add se screening filter to draft templates
f48bbc3
@ajrbyers @joemull
#4417 adds filter to revision complete updates pii filter description
578ed7b
@ajrbyers @joemull
#4417 add custom_reply_to to send_revisions_complete
a4118de
@ajrbyers @joemull
#4417 addd migration to add pii filter to templates
e137592
@ajrbyers @joemull
#4417 adds a test for edited views.
ae03ef9
@ajrbyers @joemull
#4417 change setting description
b88d0b4
@ajrbyers @joemull
#4417 fix typo
e77d7a7
@ajrbyers @joemull
#4417 changes wording and marks for translation
fafc5ce
@ajrbyers @joemull
#4417 updates test.
dc710dd
@ajrbyers @joemull
#4417 Add security decorator to file_history view.
e439093
@ajrbyers @joemull
#4417 fix visible pii.
9a400a8
@ajrbyers @joemull
#4417 include department in checks.
26b8d1c
@ajrbyers @joemull
#4417 adds additional PII to test.
2e7b1b1
@joemull joemull mentioned this pull request Sep 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauromsl mauromsl mauromsl left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Context lost during account registration
3 participants
@joemull @mauromsl @ajrbyers