Context lost during account registration

[joemull]

User story

As a prospective library supporter, I might fill out the subsidy fee calculator to check my fee, then click start signup, where I will then be asked to log in (for email verification and spam blocking).

But after I finish the account signup process, I am not brought back to the supporter signup page, and I'm not given an explanation for why. This means I will have to realize what has happened, relocate the signup page and refill in my info from the calculator page that would otherwise be carried through with GET params.

Janeway version

1.5.1

Expected behavior

Scenario: I try to access a page that requires a login and I am redirected.

• As a logged-out account holder, I am brought back to the target page after logging in
• As a logged-out account holder who has forgotten my password, I am brought back to the target page after resetting my password
• As someone with no account, I am brought back to the target page after creating and activating an account
• As a logged-out ORCID holder, I am brought back to the target page after signing in via the ORCID website
• The new templates created for Bring authentication and account pages into back office #4380 are edited

Context

We do not fully implement the Django authentication system. If we did, managing this would be a lot easier. But we want to maintain our own sets of views so that we can support ORCID authentication.

[joemull]

@ajrbyers you mentioned this week that OIDC requires a next URL, which is why one is provided here:

https://github.com/BirkbeckCTP/janeway/blob/15a708d337dce9679df488a5e2753aefb9858d1c/src/themes/OLH/templates/core/login.html#L31

Can you say why it sends people to the site index, rather than the dashboard, which is where the other login pathways end?

[ajrbyers]

@ajrbyers you mentioned this week that OIDC requires a next URL, which is why one is provided here:

https://github.com/BirkbeckCTP/janeway/blob/15a708d337dce9679df488a5e2753aefb9858d1c/src/themes/OLH/templates/core/login.html#L31

Can you say why it sends people to the site index, rather than the dashboard, which is where the other login pathways end?

It can be altered to go to the dashboard if prefered.