Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editors, authors and readers can get thank-you emails to their librarian #414

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

joemull
Copy link
Member

@joemull joemull commented Nov 18, 2024

Note that there are a few odd display things about the screenshot below (the art is in the wrong place and the header is halfway down) but that is just a side effect of the screenshot.

Screenshot 2024-11-18 at 14-22-34 Recommend us - Test A

@rhb123
Copy link
Contributor

rhb123 commented Nov 19, 2024

Thanks so much @joemull - looks great! I've added changes at https://birkbeckuol.sharepoint.com/:w:/r/sites/ac-ts-arts-olh/_layouts/15/doc.aspx?sourcedoc=%7B49a6875b-f5dd-4395-9190-2175daa1fd01%7D&action=edit and a screenshot to show what I had in mind. Just let me know if you need any more info - thanks again :)

@rhb123
Copy link
Contributor

rhb123 commented Nov 19, 2024

Recommend us - mockup

Pasting my quick mockup using the Our team page so you can see what I had in mind for the blue bar at the top @joemull - thanks again!

@ajrbyers
Copy link
Member

@joemull do you want me to hold off on reviewing this until @rhb123's changes are in place?

@joemull
Copy link
Member Author

joemull commented Nov 21, 2024

@joemull do you want me to hold off on reviewing this until @rhb123's changes are in place?

OK, they're in place now @ajrbyers.

@joemull
Copy link
Member Author

joemull commented Nov 21, 2024

Thanks for you comments @rhb123. I've implemented everything except a few small things, which I've commented on in the Word doc.

@joemull joemull removed the request for review from rhb123 November 21, 2024 15:02
@rhb123
Copy link
Contributor

rhb123 commented Nov 22, 2024

Great, thanks Joe! That all sounds good - just let me know when it goes live.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants