feature: Expose OLCesiumOptions #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Downstream projects find it helpful to be able to reuse the type definition of the constructor options for the main OLCesium object.
ejn
force-pushed
the
feature/export-olcesium-constructor-options-as-type
branch
from
e0d7a0b to
c88ea4a
Compare
gberaudo
approved these changes
Dec 3, 2024
|
Looks sensible, thanks @ejn. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream projects find it helpful to be able to reuse the type definition of the constructor options for the main OLCesium object.
I also corrected the type of the
sceneOptionsoption: Thecanvasandscene3DOnlyoptions are set internally and so should not be passed as part of thesceneOptions. Previouslycanvasstrictly had to be passed as it is defined as a non-optional member ofSceneOptions.