generate istio destinationRule subset from pod-template-hash #212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and add fields to allow user set canary/stable subset name
Ⅰ. Describe what this PR does
Behaviors if this PR merged:
when work with Istio for trafficRouting, if
spec.strategy.canary.disableGenerateCanaryService
is settrue
and Istio DestinationRule is provided, Rollout will append a canary subset for DestinationRule. The stable subset(if not provided in DestinationRule, stable subset will be create also) and canary subset are distinguished by label selectors, which are respectively pod-template-hash of v1 and v2.User is allowed to set subset name of stable subset and canary subset, via
spec.strategy.canary.trafficRoutings[x].additionalParams
, such asⅡ. Does this pull request fix one issue?
no
Ⅲ. Special notes for reviews
will update doc later