Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed size image #24

Merged
merged 7 commits into from
Dec 11, 2020
Merged

Fixed size image #24

merged 7 commits into from
Dec 11, 2020

Conversation

auloin
Copy link
Contributor

@auloin auloin commented Dec 8, 2020

No description provided.

@auloin auloin requested a review from jbelien December 8, 2020 12:16
@auloin auloin marked this pull request as ready for review December 9, 2020 14:26
jbelien
jbelien requested changes Dec 9, 2020
View reviewed changes
Copy link
Member

@jbelien jbelien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ! 👍

Could you center the activity icon in the box (like you did with people picture) ?
Thanks.

@auloin
Copy link
Contributor Author

auloin commented Dec 11, 2020

Could you center the activity icon in the box (like you did with people picture) ?

I spent some time on this... I don't think it would be as easy to achieve, nor that the result would be as great, as for the headshots. The icons could be of different sizes.

@jbelien jbelien merged commit 25f74fb into main Dec 11, 2020
@jbelien jbelien deleted the fixed-size-image branch December 11, 2020 12:02
@jbelien
Copy link
Member

jbelien commented Dec 11, 2020

I spent some time on this... I don't think it would be as easy to achieve, nor that the result would be as great, as for the headshots. The icons could be of different sizes.

No worries, not really urgent or important.
I created an issue #27 to keep it in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbelien jbelien jbelien requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@auloin @jbelien