Update JavaFXPlugin to lazy-load and configure task #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation ---------- When using the JavaFX Gradle plugin in conjunction with Gradle Enterprise, the build scan identified that this plugin was eagerly loading a task into the task graph when it did not need to. This slows down large builds with hundreds of modules and tasks. Since Gradle 5.0 the concept of task configuration avoidance [1] was added. This helps speed up builds by only registering tasks when they are needed. This commit updates the JavaFX plugin to use task configuration avoidance. Modifications ------------- Moving to task configuration avoidance is fairly straightforward. There is a guide in the documentation [1]. The instance of the create() method was changed to the corresponding register() method. Result ------ The result is a Gradle plugin that leverages task configuration avoidance improving build times. [1] https://docs.gradle.org/current/userguide/task_configuration_avoidance.html
|
This PR has conflicts now that #151 was merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update JavaFXPlugin to lazy-load and configure task
Motivation
When using the JavaFX Gradle plugin in conjunction with Gradle Enterprise, the build scan identified that this plugin was eagerly loading a task into the task graph when it did not need to. This slows down large builds with hundreds of modules and tasks. Since Gradle 5.0 the concept of task configuration avoidance was added. This helps speed up builds by only registering tasks when they are needed. This commit updates the JavaFX plugin to use task configuration avoidance.
Modifications
Moving to task configuration avoidance is fairly straightforward. There is a guide in the documentation. The instance of the create() method was changed to the corresponding register() method.
Result
The result is a Gradle plugin that leverages task configuration avoidance improving build times.