7903920: Support building jtreg on FreeBSD

[snake66]

On FreeBSD we need to use GNU gmake instead of the BSD make program.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Error

 ⚠️ OCA signatory status must be verified

Issue

• CODETOOLS-7903920: Support building jtreg on FreeBSD (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jtreg.git pull/237/head:pull/237
$ git checkout pull/237

Update a local copy of the PR:
$ git checkout pull/237
$ git pull https://git.openjdk.org/jtreg.git pull/237/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 237

View PR using the GUI difftool:
$ git pr show -t 237

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jtreg/pull/237.diff

[bridgekeeper]

Hi @snake66, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user snake66" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[snake66]

/covered

[bridgekeeper]

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[snake66]

This work is done on behalf of The FreeBSD Foundation. https://oca.opensource.oracle.com/api/v1/members/public?&search=FreeBSD

[sormuras]

Thanks for creating the PR, @snake66 - can you please create a JBS issue for this change? Happy to help if needed: https://bugs.openjdk.org/browse/CODETOOLS

@jonathan-gibbons wrote in 8a66b3b#commitcomment-150335752

Stylistically, it would be more in keeping to determine the absolute path on FreeBSD, instead of just relying on $PATH. You can do this either by checking the OS name or by checking in standard well-known places in order to determine an absolute path. See examples of other variables nearby.

Seems like this change avoids relying on $PATH. Do you also consider doing something similar for zip and unzip in this change set?

[snake66]

Thanks for creating the PR, @snake66 - can you please create a JBS issue for this change? Happy to help if needed: https://bugs.openjdk.org/browse/CODETOOLS

Thanks, I'm not sure if I have access to create issues? The credentials for the oracle account did not work.

Seems like this change avoids relying on $PATH. Do you also consider doing something similar for zip and unzip in this change set?

Yes, I was unsure if those changes would pass, so I'll follow your recommendations.

Do you want me to include the rest of the FreeBSD related changes to this PR, or is it preferable to do separate PR's for each change?

[sormuras]

Created https://bugs.openjdk.org/browse/CODETOOLS-7903920 to track this improvement to jtreg's build system "in one go".